Making the errors more specific and checking the address for typing errors #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of looking for the address right away, it first checks if an argument is provided, and if it is, it check if the address is valid aka starts with nimble1 and is 45 characters long
|
Added an additional check in case the address provided is typed wrong or is too long |
Dereek69
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It really bothered me that the error for when no job available was something that made me thing the miner was broken.
So i added an exception for the Error 500 which is the one you guys are using for no job, and then it still defaults to the old error message for all the other responses other than 200 and 500