Fix TCPSocket constructor exception safety #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes closing a TCPSocket's raw socket if something goes wrong in the constructor. Presently if the socket gets opened but something else goes wrong then the file descriptor(FD) is left dangling and can quickly exhaust the system FD limit
tony-p
reviewed
Nov 26, 2024
| socket_->Close(); | ||
| } | ||
| } | ||
| void do_not_cleanup() { |
There was a problem hiding this comment.
This is not called anywhere, which means the file descriptor is always cleaned up after the constructor is finished
tony-p
reviewed
Nov 26, 2024
| socket_scope_cleanup(TCPSocket* socket):socket_(socket){} | ||
| ~socket_scope_cleanup() { | ||
| if(should_cleanup) { | ||
| Logger(LogLevel::DEBUG) << "Close TCP socket fd=" << _sockedFd; |
There was a problem hiding this comment.
Suggested change
| Logger(LogLevel::DEBUG) << "Close TCP socket fd=" << _sockedFd; | |
| Logger(LogLevel::DEBUG) << "Close TCP socket fd=" << socket_->_sockedFd; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes closing a TCPSocket's raw socket if something goes wrong in the constructor. Presently if the socket gets opened but something else goes wrong then the file descriptor(FD) is left dangling and can quickly exhaust the system FD limit