Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting and cleanup #86

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Formatting and cleanup #86

wants to merge 6 commits into from

Conversation

JohannesKauffmann
Copy link
Collaborator

  • Prevent copy of sockaddr_in when calling getAddr()
  • Formatting and cleanup (newline, spaces etc.)
  • Group headers according to stdlib, internal, and sort them
  • Fixed some warnings (Wsign-compare, unused variables/parameters)

@JohannesKauffmann
MessageRouter: Remove trailing semicolon
f0006a0 
[35/90] Building CXX object src/CMakeFiles/EIPScanner.dir/MessageRouter.cpp.obj
/EIPScanner/src/MessageRouter.cpp:27:7: warning: extra ‘;’ [-Wpedantic]
   27 |     {};
      |       ^
@JohannesKauffmann
Fixed unused parameters/variables warnings
32035b9 
Remove the void cast and unname them instead, per C++ Core Guidelines:

https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#f9-unused-parameters-should-be-unnamed

For the assert, use the maybe_unused attribute.
@JohannesKauffmann
Prevent copy of sockaddr_in when calling getAddr()
f3aecbb 
Visual Studio generated a note about this (lnt-accidental-copy).

UDPBoundSocket.cpp's usage of getAddr() has been left untouched, as to
not change behaviour there (it writes to the value returned by
getAddr()).
@JohannesKauffmann
Fix some Wsign-compare warnings
23eec08 
To avoid creating a new warning in DiscoveryManager.cpp, use
static_cast. The IdentityObject takes a CipUint anyway.

On Windows, setsocktopt() with SO_RCVTIMEO takes a uint32_t, but
std::chrono::duration::count() returnes a "signed integer type of at
least 45 bits" [1], so it also produces a warning.

[1]. https://en.cppreference.com/w/cpp/chrono/duration
@JohannesKauffmann
Group headers, add newlines, formatting
7d14b81 
Headers are now grouped using a newline, ranging from standard library,
to external (GTest) headers, and finally our own headers.

Commented out and duplicate #includes removed.

Removed "private" immediately followed by "public".

Also added a newline to the last line of every file.
@JohannesKauffmann
Removed erroneous spaces where applicable
a484342 
Also fixed a spelling mistake.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JohannesKauffmann