This repository has been archived by the owner on Jan 24, 2025. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validator registration tool #645
Validator registration tool #645
Changes from all commits
7d72573
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each further transaction sending should maybe fail, if a tx fails to send? E.g. if it reports as
result.state === 'new'
?If the txs are all in the same block, their order is not guaranteed I think. Is the PoS genesis-generating script able to work with unsorted transactions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, since they are 0 value txns they should not fail..
The PoS generation script is able to work with unsorted transactions:
As part of the encoding that we created for the tx data, we are using 1 byte as "type" which is just a number to indicate the order of the registration txn. So the migration tool will look this number to sort the registration txns.