Network: close connection for all discovery errors

nimiq · Jan 15, 2025 · 4f70084 · 4f70084
1 parent 91c35ba
commit 4f70084
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/network-libp2p/src/discovery/behaviour.rs b/network-libp2p/src/discovery/behaviour.rs
@@ -11,7 +11,7 @@ use libp2p::{
     identity::Keypair,
     swarm::{
         behaviour::{ConnectionClosed, ConnectionEstablished},
-        ConnectionDenied, ConnectionId, FromSwarm, NetworkBehaviour, ToSwarm,
+        CloseConnection, ConnectionDenied, ConnectionId, FromSwarm, NetworkBehaviour, ToSwarm,
     },
     Multiaddr, PeerId,
 };
@@ -297,8 +297,10 @@ impl NetworkBehaviour for Behaviour {
                     .push_back(ToSwarm::NewExternalAddrCandidate(observed_address));
             }
             HandlerOutEvent::Update => self.events.push_back(ToSwarm::GenerateEvent(Event::Update)),
-            // Errors must not result in a closed connection as light clients are unable to verify ValidatorRecord.
-            HandlerOutEvent::Error(error) => log::trace!(?error, "Received invalid contact"),
+            HandlerOutEvent::Error(_) => self.events.push_back(ToSwarm::CloseConnection {
+                peer_id,
+                connection: CloseConnection::All,
+            }),
         }
     }
 }