Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 2 new arts #3

Merged
merged 2 commits into from
Nov 22, 2021
Merged

Adding 2 new arts #3

merged 2 commits into from
Nov 22, 2021

Conversation

CodesOfRishi
Copy link
Contributor

Added 2 new ASCII arts named,

  • linuxrules
  • redhat

Files containing both the ASCII art resides in ascii_arts/ directory.

@BeyondMagic BeyondMagic added the art About an art label Nov 22, 2021
@BeyondMagic
Copy link
Contributor

Thank you so much!!!

@BeyondMagic BeyondMagic merged commit 4eb69a3 into ninecath:master Nov 22, 2021
@BeyondMagic
Copy link
Contributor

Actually, can you me confirm to me that linuxrules is yours or from hjm? If the latter, the first comment is designed to credit the original creator and authors who modify the art.

Of course there's no copyright behind ASCII arts, but I would like to follow the respect ASCII artists campaign for kindness.

@CodesOfRishi
Copy link
Contributor Author

CodesOfRishi commented Nov 23, 2021

Yes, it's not mine, I got both of the arts from ASCII Art Archive website.
I wasn't aware of the respect ASCII artists campaign.
Please, do inform me if I did anything that I shouldn't have done or anything else I should take care of from here onwards.

If you say, I can create another PR crediting the source(s) or artist(s).

Thanks

@BeyondMagic
Copy link
Contributor

BeyondMagic commented Nov 23, 2021

I understand, the campaign is listed on README.md as an image, but I should've have made that clear on the adding arts section.

Anyways, thanks for the contributions for now, I will revert the changes of this PR so that you can add a new PR linking to the original authors as I don't have the names besides the first one from hjm.


As for creating new arts, I understand that it's difficult now since writing ASCII art on terminal has always been tiresome, so I'm been working on this issue separately #1.

BeyondMagic added a commit that referenced this pull request Nov 23, 2021
BeyondMagic added a commit that referenced this pull request Nov 23, 2021
BeyondMagic pushed a commit that referenced this pull request Nov 23, 2021
* ARTS: add redhat
* ARTS: add linuxrules
| `. | `' \Zq
_) \.___.,| .'
\____ )MMMMMM| .'
`-' `--' hjm
Copy link
Contributor

@BeyondMagic BeyondMagic Nov 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, you could remove his/her artist name (hjm) and put it at the first line.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
art About an art
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants