Wintest

.flake8

@@ -4,13 +4,19 @@ ignore =
     W503,  # line break before binary operator (Black)
 
 per-file-ignores =
+    # Files and directories which need fixes or specific exceptions
+    # Many of these ignores can and should be removed and the problem fixed.
     # Quick reference for some of the most common errors
+    # F403 star import used; unable to detect undefined names
+    # F405 variable may be undefined, or defined from star imports
+    # E402 module level import not at top of file
     # E501 line too long
     # E722 do not use bare 'except'
     # W605 invalid escape sequence
     # F401 imported but unused
     # F821 undefined name 'unicode'
     # F841 local variable assigned to but never used
+    # E741 ambiguous variable name 'l'
     lib/init/grass.py: E501, E722, F821, F841, W605
     utils/mkrest.py: E501, W605
     utils/gitlog2changelog.py: E722, E712, W605
@@ -37,6 +43,187 @@ per-file-ignores =
     locale/grass_po_stats.py: E122, E128, E231, E401, E501, E722, E741
     gui/scripts/d.rast3d.py: E501
     gui/scripts/d.wms.py: E501
+    gui/wxpython/core/debug.py: E501
+    gui/wxpython/core/gcmd.py: E402, E501
+    gui/wxpython/core/giface.py: E501
+    gui/wxpython/core/gthread.py: F841
+    gui/wxpython/core/gconsole.py: E722, W605
+    gui/wxpython/core/toolboxes.py: E722, E501
+    gui/wxpython/core/utils.py: E722, F841, W605
+    gui/wxpython/core/workspace.py: E722, E501
+    gui/wxpython/core/render.py: E722, F841, E501
+    gui/wxpython/core/ws.py: F841, E501
+    gui/wxpython/core/settings.py: E722
+    gui/wxpython/datacatalog/tree.py: E731, E402, E501
+    gui/wxpython/dbmgr/base.py: E501, E722, F841
+    gui/wxpython/dbmgr/dialogs.py: E501, F841, E722
+    gui/wxpython/dbmgr/sqlbuilder.py: E501, E722, F841
+    gui/wxpython/dbmgr/manager.py: E501, E722
+    gui/wxpython/dbmgr/vinfo.py: F841
+    gui/wxpython/docs/wxgui_sphinx/conf.py: E402, E501
+    gui/wxpython/gcp/g.gui.gcp.py: F841
+    gui/wxpython/gcp/manager.py: E501, F841, E722
+    gui/wxpython/gcp/mapdisplay.py: F841
+    gui/wxpython/gmodeler/*: F841, E722, W605, F405, F403, E402
+    gui/wxpython/gui_core/*: F841, E266, E722, W605
+    gui/wxpython/gui_core/dialogs.py: E501, E722, F841, W605
+    gui/wxpython/gui_core/forms.py: E501, E722, F841
+    gui/wxpython/gui_core/ghelp.py: E501, E722
+    gui/wxpython/gui_core/gselect.py: E501, F841, E266, E722
+    gui/wxpython/gui_core/preferences.py: E501, E266, F841
+    gui/wxpython/gui_core/treeview.py: E501, F841
+    gui/wxpython/gui_core/widgets.py: E501, F841, E722, E266
+    gui/wxpython/image2target/*: F841, E722, E265, E501
+    gui/wxpython/iscatt/*: F841, E722, E741, F405, F403, E501
+    gui/wxpython/lmgr/giface.py: E501, E741
+    gui/wxpython/lmgr/frame.py: F841, E722, W605, E501
+    # layertree still includes some formatting issues (it is ignored by Black)
+    gui/wxpython/lmgr/layertree.py: E722, E266, W504, E225, E501
+    gui/wxpython/lmgr/workspace.py: F841
+    gui/wxpython/modules/*: F841, E722, W605, E501
+    gui/wxpython/nviz/*: F841, E266, E722, W605, F403, F405, E501
+    gui/wxpython/photo2image/*: F841, E722, E265, E501
+    gui/wxpython/psmap/*: F841, E266, E722, F405, F403, E501
+    gui/wxpython/vdigit/*: F841, E722, E741, F405, F403, E501
+    gui/wxpython/vnet/*: F841, E501
+    gui/wxpython/wxgui.py: F841
+    gui/wxpython/animation/g.gui.animation.py: E501
+    gui/wxpython/animation/mapwindow.py: F841
+    gui/wxpython/animation/provider.py: F841, E501
+    gui/wxpython/animation/temporal_manager.py: E501
+    gui/wxpython/tplot/frame.py: F841, E722
+    gui/wxpython/tplot/g.gui.tplot.py: E501
+    gui/wxpython/rdigit/g.gui.rdigit.py: F841
+    gui/wxpython/rdigit/toolbars.py: E501
+    gui/wxpython/iclass/dialogs.py: E741, E501
+    gui/wxpython/iclass/digit.py: F405, F403
+    gui/wxpython/iclass/frame.py: F405, F403, E501
+    gui/wxpython/iclass/g.gui.iclass.py: E501
+    gui/wxpython/iclass/statistics.py: F841, F405, F403
+    gui/wxpython/wxplot/dialogs.py: E501
+    gui/wxpython/wxplot/histogram.py: E722
+    gui/wxpython/wxplot/profile.py: F841, E722
+    gui/wxpython/wxplot/base.py: F841, E722
+    gui/wxpython/wxplot/scatter.py: E501
+    gui/wxpython/location_wizard/dialogs.py: F841, E501
+    gui/wxpython/location_wizard/wizard.py: E722
+    gui/wxpython/mapdisp/frame.py: E501
+    gui/wxpython/mapdisp/main.py: E722, E501
+    gui/wxpython/mapdisp/test_mapdisp.py: E501
+    gui/wxpython/mapdisp/toolbars.py: E501
+    gui/wxpython/mapdisp/statusbar.py: F841, E501
+    gui/wxpython/mapswipe/g.gui.mapswipe.py: E501
+    gui/wxpython/mapwin/base.py: E722, E501
+    gui/wxpython/mapwin/buffered.py: E722, E501
+    gui/wxpython/mapwin/decorations.py: E501
+    gui/wxpython/mapwin/graphics.py: E722
+    gui/wxpython/startup/locdownload.py: E722, E402, E501
+    gui/wxpython/timeline/g.gui.timeline.py: E501
+    gui/wxpython/tools/build_modules_xml.py: E722, E501
+    gui/wxpython/web_services/cap_interface.py: E501
+    gui/wxpython/web_services/dialogs.py: E501
+    gui/wxpython/web_services/widgets.py: F841, E741, W605, E402, E501
+    gui/wxpython/rlisetup/frame.py: E741
+    gui/wxpython/rlisetup/sampling_frame.py: F841
+    gui/wxpython/rlisetup/wizard.py: E722, E741
+    # Generated file
+    gui/wxpython/menustrings.py: E501
+    # F821 undefined name 'cmp'
+    # https://github.com/OSGeo/grass/issues/1809
+    python/grass/pydispatch/saferef.py: F821
+    # C wrappers call libgis.G_gisinit before importing other modules.
+    # TODO: Is this really needed?
+    python/grass/pygrass/vector/__init__.py: E402,
+    python/grass/pygrass/raster/__init__.py: E402,
+    python/grass/gunittest/*.py: E501  # These are mainly just todo comments
+    python/grass/gunittest/gmodules.py: E501, W605
+    python/grass/pygrass/vector/geometry.py: W605
+    python/grass/pygrass/vector/table.py: E501
+    python/grass/pygrass/vector/__init__.py: E501, E402
+    python/grass/pygrass/modules/interface/*.py: E501, F401
+    python/grass/pygrass/modules/interface/module.py: E501, W605
+    python/grass/pygrass/modules/interface/parameter.py: E501, W605
+    python/grass/pygrass/modules/grid/*.py: E501, F401
+    python/grass/pygrass/raster/*.py: E501
+    python/grass/pygrass/raster/rowio.py: E741
+    python/grass/pygrass/rpc/__init__.py: E501, F401, F403
+    python/grass/pygrass/utils.py: E402, E501
+    python/grass/script/db.py: E501
+    python/grass/script/task.py: W605
+    python/grass/script/vector.py: E501  # Long doctest lines which need review anyway
+    python/grass/temporal/abstract_map_dataset.py: E501
+    python/grass/temporal/abstract_space_time_dataset.py: W605, E501, F841, E722
+    python/grass/temporal/aggregation.py: E501
+    python/grass/temporal/base.py: E501
+    python/grass/temporal/c_libraries_interface.py: E501, F841, E722
+    python/grass/temporal/core.py: E501, E722
+    python/grass/temporal/datetime_math.py: E501, F841, E722
+    python/grass/temporal/list_stds.py: E501
+    python/grass/temporal/metadata.py: E501
+    python/grass/temporal/open_stds.py: F841
+    python/grass/temporal/register.py: E501
+    python/grass/temporal/space_time_datasets.py: E501
+    python/grass/temporal/spatial_extent.py: E501
+    python/grass/temporal/spatial_topology_dataset_connector.py: E501, E722
+    python/grass/temporal/spatio_temporal_relationships.py: E501
+    python/grass/temporal/temporal_algebra.py: E741, E501, F841, E722
+    python/grass/temporal/temporal_extent.py: E501
+    python/grass/temporal/temporal_granularity.py: E501, F841, E722
+    python/grass/temporal/temporal_operator.py: E501
+    python/grass/temporal/temporal_raster_algebra.py: E741
+    python/grass/temporal/temporal_raster_base_algebra.py: E501, F841, E722
+    python/grass/temporal/temporal_raster3d_algebra.py: E741
+    python/grass/temporal/temporal_topology_dataset_connector.py: E501, E722
+    python/grass/temporal/temporal_vector_algebra.py: E741, E501, F841
+    python/grass/temporal/univar_statistics.py: E501
+    # Current benchmarks/tests are changing sys.path before import.
+    # Possibly, a different approach should be taken there anyway.
+    python/grass/pygrass/tests/benchmark.py: E501, E402, F401, F821
+    # Configuration file for Sphinx:
+    # Ignoring import/code mix and line length.
+    python/grass/docs/conf.py: E402, E501,
+    # Files not managed by Black
+    python/grass/imaging/images2gif.py: E226, E501
+    # Unused imports in init files
+    # F401 imported but unused
+    # F403 star import used; unable to detect undefined names
+    python/grass/*/__init__.py: F401, F403
+    python/grass/*/*/__init__.py: F401, F403
+    python/grass/*/*/*/__init__.py: F401, F403
+    # E402 module level import not at top of file
+    scripts/d.polar/d.polar.py: F841, E501
+    scripts/r.in.wms/wms_gdal_drv.py: F841, E722, E501
+    scripts/r.in.wms/wms_cap_parsers.py: F841, E741, E501
+    scripts/r.in.wms/wms_drv.py: E402, E722, E501
+    scripts/r.in.wms/srs.py: E722, E501
+    scripts/r.semantic.label/r.semantic.label.py: F841, E501
+    scripts/v.report/v.report.py: F841, E501
+    scripts/db.out.ogr/db.out.ogr.py: F841
+    scripts/g.extension/g.extension.py: F841, E722, E501
+    scripts/r.unpack/r.unpack.py: E722, E501
+    scripts/v.unpack/v.unpack.py: F841, E722, E501
+    scripts/v.import/v.import.py: F841, E722, E501
+    scripts/db.univar/db.univar.py: E741, E501
+    scripts/d.rast.leg/d.rast.leg.py: E741
+    scripts/d.frame/d.frame.py: E722, E501
+    scripts/i.pansharpen/i.pansharpen.py: E722, E501
+    scripts/r.in.srtm/r.in.srtm.py: E722, E501
+    scripts/r.fillnulls/r.fillnulls.py: E722, E501
+    scripts/d.rast.edit/d.rast.edit.py: E722, E501
+    scripts/v.what.strds/v.what.strds.py: E722, E501
+    scripts/i.in.spotvgt/i.in.spotvgt.py: E722, E501
+    # Line too long (esp. module interface definitions)
+    scripts/*/*.py: E501
+    # local variable 'column' is assigned to but never used
+    temporal/t.rast.to.vect/t.rast.to.vect.py: F841, E501
+    # local variable 'stdstype' is assigned to but never used
+    temporal/t.vect.algebra/t.vect.algebra.py: F841, E501
+    # ## used (##% key: r etc)
+    # local variable 'map_list' is assigned to but never used
+    temporal/t.rast.what/t.rast.what.py: E265, E266, F841, E501
+    # Line too long (esp. module interface definitions)
+    temporal/*/*.py: E501
+
 
 max-line-length = 88
 exclude =
@@ -55,11 +242,8 @@ exclude =
     OBJ.*,
     # Test output directory
     testreport,
-    # Have their own configs for now
-    python/grass,
-    gui/wxpython,
-    scripts/*/*.py,
-    temporal/*/*.py,
+    # Not yet compliant
+    python/libgrass_interface_generator,
     # No tests checked for now
     testsuite,
 

.git-blame-ignore-revs

@@ -0,0 +1,25 @@
+# Format Python code with Black
+1aab3bbcff76c12d422e7dffd9aba8277f91cd86
+0d9e966dd289753cca91886529e65711eaf863eb
+57cb2d4bbe6ce71a8b97fce42dd4da736c18e636
+6d4d14afb3845a8ecdcef391f3375d97af4a6a84
+7e03dcd6a8d7d96ead53d0f72e57735050dc6c7a
+feff8e340f5fec1b52ce066360904f72501e76ce
+fd86f50e9a4c9ab37cf501290349790377846b59
+ff2c2290d1469972504753e5d1415eba5568e196
+e9dfbc4eee6fa14af2f0a8a5e1a7c723b34254db
+02bfae03d5db8c80a93a0e340ff3cdcd509a2785
+0111b11e8b3aae2c55f20eb1ceea3dc4ee86cee9
+# Major C formatting in 2008
+8868d4b6868e05345c93032704b7304de04c1daf
+# Per-file or per-directory C code formatting
+c08f63b1b604acbba275c144b543c5164bc9f432
+8eaef1f4e6e9497f469cbb7ab91fe03389a6b49b
+f6a73088a9c17b6cce7102c5c3107ab4b41f3b2c
+# parser: Use #-space-% to allow writing PEP8-compliant Python code (#1287)
+635224115c5ee9c29a9356210c3b03e5511ef6dc
+# Format shell/Bash scripts
+80bcf7a290a6a1249604b2c8a236154f13e25bfa
+a0ccdb551e004a0f68192fb65cfc9be61b2880ed
+# Format YAML in GH workflows (#1367)
+567fa0643d0ab48de590ffbf0e286a288d359312

.github/FUNDING.yml

@@ -1 +1 @@
-custom: https://www.paypal.com/pools/c/86YKZiIEPV
+open_collective: grass

.github/codeql/codeql-config.yml

@@ -0,0 +1,7 @@
+name: "CodeQL config"
+paths-ignore:
+  - "**/testsuite/**"
+  - "bin.*"
+  - "dist.*"
+  - node_modules
+  - python/grass/pygrass/tests

.github/workflows/README.md

@@ -4,7 +4,7 @@
 
 Run locally using Docker:
 
-```
+```bash
 docker run --rm -e RUN_LOCAL=true -e VALIDATE_PERL=true -v $PWD:/tmp/lint github/super-linter
 ```
 

.github/workflows/additional_checks.yml

@@ -0,0 +1,56 @@
+name: Additional Checks
+
+# Checks which are not in standardized tools such as custom checks by scripts
+# in the source code or small 3rd party checks without large projects behind them.
+# Number of disconnected, but simple checks can be combined into one workflow
+# (and job) to reduce the number of jobs.
+
+on:
+  push:
+    branches:
+      - main
+      - releasebranch_*
+  pull_request:
+    branches:
+      - main
+      - releasebranch_*
+
+jobs:
+  additional-checks:
+    name: Additional checks
+    runs-on: ubuntu-20.04
+
+    steps:
+      - name: Checkout repository contents
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 31
+
+      - name: Check for CRLF endings
+        uses: erclu/check-crlf@v1
+        with:
+          # Ignore all test data, Windows-specific directories and scripts.
+          exclude: mswindows .*\.bat .*/testsuite/data/.*
+
+      - name: Set up Python
+        uses: actions/setup-python@v2
+        with:
+          python-version: "3.10"
+
+      - name: Generate core modules with last commit JSON file and test it
+        run: |
+          python -m pip install pytest pytest-depends
+          python utils/generate_last_commit_file.py .
+          pytest utils/test_generate_last_commit_file.py
+
+      - name: Generate release notes using git log
+        run: |
+          python -m pip install PyYAML
+          # Git works without any special permissions.
+          # Using current branch or the branch against the PR is open.
+          # Using the last 30 commits (for branches, tags, and PRs).
+          # End is the current (latest) commit.
+          python ./utils/generate_release_notes.py log \
+              ${{ github.ref_name }} \
+              $(git rev-parse HEAD~30) \
+              ""

.github/workflows/apt.txt

@@ -12,13 +12,16 @@ libopenblas-dev
 libpdal-dev
 libpng-dev
 libproj-dev
-pdal
-proj-bin
 libreadline-dev
 libzstd-dev
+pdal
+proj-bin
 python3-dateutil
+python3-matplotlib
 python3-numpy
+python3-pil
 python3-ply
+python3-pyvirtualdisplay
 python3-six
 python3-termcolor
 sqlite3

.github/workflows/black.yml

@@ -1,26 +1,42 @@
 name: Python Black Formatting
 
 on:
-  - push
-  - pull_request
+  push:
+    branches:
+      - main
+      - releasebranch_*
+  pull_request:
+    branches:
+      - main
+      - releasebranch_*
 
 jobs:
   run-black:
-    name: Check
-    runs-on: ubuntu-20.04
+    name: Black ${{ matrix.black-version }}
+
+    # Using matrix just to get variables which are not environmental variables
+    # and also to sync with other workflows which use matrix.
+    strategy:
+      matrix:
+        include:
+          - os: ubuntu-20.04
+            python-version: "3.10"
+            black-version: "22.3.0"
+
+    runs-on: ${{ matrix.os }}
 
     steps:
       - uses: actions/checkout@v2
 
       - name: Set up Python
         uses: actions/setup-python@v2
         with:
-          python-version: 3.8
+          python-version: ${{ matrix.python-version }}
 
       - name: Install
         run: |
           python -m pip install --upgrade pip
-          pip install black==21.5b1
+          pip install black==${{ matrix.black-version }}
 
       - name: Run Black
         run: |