TST: Parametrize JoinNode expansion tests over config needed_outputs

[oesteban]

Will help better test #2971.

Acknowledgment

• (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

[effigies]

This config thing is changing global state, so we should probably restore the original value at the end of the function. Or mock config, if that seems worth the effort.

[codecov]

Codecov Report

Merging #2981 into master will decrease coverage by 2.82%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2981      +/-   ##
==========================================
- Coverage   67.08%   64.25%   -2.83%     
==========================================
  Files         343      342       -1     
  Lines       43767    43730      -37     
  Branches     5466     5466              
==========================================
- Hits        29361    28099    -1262     
- Misses      13687    14536     +849     
- Partials      719     1095     +376

Flag	Coverage Δ
#smoketests	?
#unittests	64.25% <ø> (ø)	⬆️

Impacted Files	Coverage Δ
nipype/utils/spm_docs.py	25.92% <0%> (-44.45%)	⬇️
nipype/utils/logger.py	59.7% <0%> (-29.86%)	⬇️
nipype/algorithms/rapidart.py	35% <0%> (-29.42%)	⬇️
nipype/utils/provenance.py	55.73% <0%> (-28.35%)	⬇️
nipype/interfaces/spm/base.py	57.94% <0%> (-27.16%)	⬇️
nipype/interfaces/fsl/model.py	55.26% <0%> (-25.35%)	⬇️
nipype/interfaces/matlab.py	64.64% <0%> (-21.22%)	⬇️
nipype/workflows/fmri/fsl/preprocess.py	72.13% <0%> (-13.94%)	⬇️
nipype/pipeline/plugins/multiproc.py	72.22% <0%> (-12.35%)	⬇️
nipype/workflows/fmri/spm/preprocess.py	60.2% <0%> (-12.25%)	⬇️
... and 32 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f2f94f...a6dab61. Read the comment docs.

[codecov]

Codecov Report

Merging #2981 into master will decrease coverage by 2.82%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2981      +/-   ##
==========================================
- Coverage   67.08%   64.25%   -2.83%     
==========================================
  Files         343      342       -1     
  Lines       43767    43730      -37     
  Branches     5466     5466              
==========================================
- Hits        29361    28099    -1262     
- Misses      13687    14536     +849     
- Partials      719     1095     +376

Flag	Coverage Δ
#smoketests	?
#unittests	64.25% <ø> (ø)	⬆️

Impacted Files	Coverage Δ
nipype/utils/spm_docs.py	25.92% <0%> (-44.45%)	⬇️
nipype/utils/logger.py	59.7% <0%> (-29.86%)	⬇️
nipype/algorithms/rapidart.py	35% <0%> (-29.42%)	⬇️
nipype/utils/provenance.py	55.73% <0%> (-28.35%)	⬇️
nipype/interfaces/spm/base.py	57.94% <0%> (-27.16%)	⬇️
nipype/interfaces/fsl/model.py	55.26% <0%> (-25.35%)	⬇️
nipype/interfaces/matlab.py	64.64% <0%> (-21.22%)	⬇️
nipype/workflows/fmri/fsl/preprocess.py	72.13% <0%> (-13.94%)	⬇️
nipype/pipeline/plugins/multiproc.py	72.22% <0%> (-12.35%)	⬇️
nipype/workflows/fmri/spm/preprocess.py	60.2% <0%> (-12.25%)	⬇️
... and 32 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f2f94f...2e9ecc1. Read the comment docs.

[oesteban]

I have tested locally in all python versions we are testing - since tests were already passing before the suggestions, I'll go ahead and merge to focus on the other PR and release some Circle/Travis resources.

[effigies]

Seems reasonable.