Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: includeSensitiveChannel not working for funout timeline #108

Merged

Conversation

anatawa12
Copy link
Collaborator

@anatawa12 anatawa12 commented Nov 28, 2023

What

Fixes #103

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@anatawa12 anatawa12 added the ⚠️Bug Something isn't working label Nov 28, 2023
Copy link

github-actions bot commented Nov 28, 2023

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -56817,8 +56817,7 @@
                     "default": false
                   },
                   "includeSensitiveChannel": {
-                    "type": "boolean",
-                    "default": false
+                    "type": "boolean"
                   }
                 },
                 "required": [

Get diff files from Workflow Page

@anatawa12
Copy link
Collaborator Author

テストも変えないとじゃーん

Copy link

@Sayamame-beans Sayamame-beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testさえ修正すれば、後は問題なさそう…?

@anatawa12
Copy link
Collaborator Author

というかtest通すためにincludeSensitiveChannelが指定されてない場合にupstreamの仕様に合わせようかなぁってなってます。

Copy link

@Sayamame-beans Sayamame-beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これ以外は一見大丈夫そうです

packages/backend/test/e2e/timelines.ts Outdated Show resolved Hide resolved
Co-authored-by: Sayamame-beans <[email protected]>
Copy link

@Sayamame-beans Sayamame-beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多分ヨシ!

@anatawa12 anatawa12 merged commit 092881e into niri-la:develop Nov 28, 2023
18 checks passed
@anatawa12 anatawa12 deleted the fix-user-include-sensitive-channel branch November 28, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

includeSensitiveChannelがredisキャッシュの範囲だと動いてない
2 participants