Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add preview to providers and custom tea lifecycle #543

Conversation

HomelessDinosaur
Copy link
Member

No description provided.

@HomelessDinosaur HomelessDinosaur force-pushed the feat/preview-tea-lifecycle branch from d48a47f to 297b54f Compare November 24, 2023 02:34
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4c00476) 57.28% compared to head (297b54f) 57.28%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #543   +/-   ##
========================================
  Coverage    57.28%   57.28%           
========================================
  Files           54       54           
  Lines         5155     5155           
========================================
  Hits          2953     2953           
  Misses        2009     2009           
  Partials       193      193           
Flag Coverage Δ
aws 58.97% <ø> (ø)
azure 61.61% <ø> (ø)
core 60.90% <ø> (ø)
gcp 45.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davemooreuws
Copy link
Member

davemooreuws commented Nov 24, 2023

Tested on windows, CLI version 1.33.1 with the AWS provider.

I am still getting that old windows delay. But I am also getting a mass duplication of the screen being printed multiple times (per view update).

image

@HomelessDinosaur
Copy link
Member Author

HomelessDinosaur commented Nov 28, 2023

Tested on windows, CLI version 1.33.1 with the AWS provider.

I am still getting that old windows delay. But I am also getting a mass duplication of the screen being printed multiple times (per view update).

This has been resolved, was using with an incompatible CLI version. I should have noted that the provider is currently only be compatible with the CLI branch feat/preview-command and any versions after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants