Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue causing missing api gateway tags on first deploy #550

Merged
merged 1 commit into from
Jan 11, 2024
Merged

fix: issue causing missing api gateway tags on first deploy #550

merged 1 commit into from
Jan 11, 2024

Conversation

jyecusch
Copy link
Member

Co-authored-by: Tim Holm [email protected]

@jyecusch jyecusch requested a review from tjholm as a code owner January 10, 2024 23:13
davemooreuws
davemooreuws reviewed Jan 10, 2024
View reviewed changes
Copy link
Member

@davemooreuws davemooreuws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. However for the v1 changes in general:

  • Looks like we need to bump to go 1.21 for the slices package. Other than that, some linting updates across the code base.

Could fix in this PR as a chore

@tjholm tjholm merged commit 54c04c3 into v1 Jan 11, 2024
0 of 3 checks passed
@tjholm tjholm deleted the fix/aws-apigateway-tags branch January 11, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davemooreuws davemooreuws davemooreuws left review comments

@tjholm tjholm tjholm approved these changes

@HomelessDinosaur HomelessDinosaur Awaiting requested review from HomelessDinosaur

Assignees

@jyecusch jyecusch

@davemooreuws davemooreuws

@tjholm tjholm

@HomelessDinosaur HomelessDinosaur

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jyecusch @davemooreuws @tjholm @HomelessDinosaur