Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dialyzer erros for cowboy 2.9.0 #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joaohf
Copy link

@joaohf joaohf commented May 19, 2023

simple_bridge/src/cowboy_bridge_modules/cowboy_simple_bridge.erl

Line 117 Column 9:
The variable _ can never match since previous clauses completely covered the type #{binary()=>binary() | maybe_improper_list(binary() | maybe_improper_list(any(),binary() | []) | byte(),binary() | [])}
Line 166 Column 9: The pattern {'error', Reason} can never match the type {'more',binary(),#{'body_length':='undefined' | non_neg_integer(), ... Line 177 Column 9: The pattern {H, L} can never match the type 'HTTP/2'

simple_bridge/src/cowboy_bridge_modules/cowboy_simple_bridge.erl

Line 117 Column 9:
   The variable _ can never match since previous clauses completely covered the type #{binary()=>binary() | maybe_improper_list(binary() | maybe_improper_list(any(),binary() | []) | byte(),binary() | [])}
Line 166 Column 9: The pattern {'error', Reason} can never match the type {'more',binary(),#{'body_length':='undefined' | non_neg_integer(), ...
Line 177 Column 9: The pattern {H, L} can never match the type 'HTTP/2'
@joaohf
Copy link
Author

joaohf commented May 19, 2023

Hello,

I'm not sure if this PR is too specific for cowboy 2.9.0. Maybe yes. In fact, how does simple_bridge detect and work with cowboy versions ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant