Various test cleanups #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were running every test ten times but there is no point to it when we do not actually use proptest generators.
This removes slowish Template Haskell step and is actually more concise since we no longer need to re-export the tests with `prop_` prefix. Also rename the test functions: - remove dconf2nix prefix - negative → numbers (this was forgotten in fb34a46) - dconf → dump
Instead of using fixed functions. This will allow us to easily add NixOS variants of the tests.
Lighen up the top-level directory a bit.
They were added in 65625df but never actually registered by the test bench. Also rename them from `quotes` to `strings`.
But keep it commented out. This is useful when adding new tests. Also move reading output just before it is compared so that it does not fail before we can write the result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.