Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Profile-sync-daemon not working correctly #5454

Open
2 tasks done
TheStachelfisch opened this issue May 26, 2024 · 5 comments · May be fixed by #6230
Open
2 tasks done

bug: Profile-sync-daemon not working correctly #5454

TheStachelfisch opened this issue May 26, 2024 · 5 comments · May be fixed by #6230
Assignees
@rycee @sumnerevans @berbiche
Labels
bug status: stale triage Issues or feature request that have not been triaged yet

Comments

@TheStachelfisch
Copy link

TheStachelfisch commented May 26, 2024 •
edited
Loading

Are you following the right branch?

  • My Nixpkgs and Home Manager versions are in sync

Is there an existing issue for this?

  • I have searched the existing issues

Issue description

Currently the newly-added services.psd.enable option doesn't work correctly due to three issues.

First issue, the psd daemon will not work, since the base config files in $HOME/.config/psd are not created, the daemon will always exit with:

First time running psd so please edit /home/USER/.config/psd/psd.conf to your liking and run again.

Second issue, if you manually add the config file, it always fails with:

profile-sync-daemon[6398]:   is not a supported browser. Check config file for typos: /home/USER/.config/psd/psd.conf

I generated the config file simply by running psd once.
This might be be a bug in psd, since if no browsers are added to the config, it should automatically manage all browsers present on the system.

Third issue, if you manually add a browser to the config, it fails, since the script PSD runs can't find needed commands in the environment.

/nix/store/nycg6pa28kh4hk1nmm6vh73gvd758vav-profile-sync-daemon-6.50/share/psd/browsers/firefox: line 15: grep: command not found
/nix/store/nycg6pa28kh4hk1nmm6vh73gvd758vav-profile-sync-daemon-6.50/share/psd/browsers/firefox: line 15: sed: command not found
/nix/store/nycg6pa28kh4hk1nmm6vh73gvd758vav-profile-sync-daemon-6.50/bin/profile-sync-daemon: line 390: id: command not found

Maintainer CC

@danjujan
@rycee

System information

- system: `"x86_64-linux"`
 - host os: `Linux 6.9.1, NixOS, 24.11 (Vicuña), 24.11.20240523.3305b2b`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.2`
 - channels(root): `"nixos"`
 - nixpkgs: `/nix/store/3qi6zkjzggmilf1sx4b979ym6fxnqsjl-source`
@TheStachelfisch TheStachelfisch added bug triage Issues or feature request that have not been triaged yet labels May 26, 2024
@danjujan
Copy link
Contributor

Thank you for the report!
Does danjujan@0d0b333 fix your third issue?

Currently the psd.conf is not managed by home-manager as I simply ported the NixOS module. Support for that is on my todo list. However, I don't have much time in the coming weeks. Maybe you can create a PR for that?

@TheStachelfisch
Copy link
Author

TheStachelfisch commented May 27, 2024 •
edited
Loading

Thank you for the report! Does danjujan@0d0b333 fix your third issue?

Currently the psd.conf is not managed by home-manager as I simply ported the NixOS module. Support for that is on my todo list. However, I don't have much time in the coming weeks. Maybe you can create a PR for that?

Sorry for the late reply, unfortunately it doesn't fix the issue.
Correction: It indeed fixed the issue, I didn't see that it was on your fork 🤦
I'll look into the other issues myself later this week and create a PR to fix it.

@danjujan
Copy link
Contributor

I'll look into the other issues myself later this week and create a PR to fix it.

Have a look at nixos/modules/services/desktops/profile-sync-daemon.nix before NixOS/nixpkgs@574f4c4. Most of the functionality was apparently there already but got removed.

@Zweihander-Main
Copy link

Same issue here and also fixed by the same patch -- danjujan@0d0b333

FYI -- also added findutils into the envPath binary list in that patch.
The psd-resync service gave me a complaint about missing find without it.

@TheStachelfisch TheStachelfisch mentioned this issue Jun 20, 2024
Closed
6 tasks
@stale Stale
Copy link

stale bot commented Sep 28, 2024

Thank you for your contribution! I marked this issue as stale due to inactivity. Please be considerate of people watching this issue and receiving notifications before commenting 'I have this issue too'. We welcome additional information that will help resolve this issue. Please read the relevant sections below before commenting.

If you are the original author of the issue

  • If this is resolved, please consider closing it so that the maintainers know not to focus on this.
  • If this might still be an issue, but you are not interested in promoting its resolution, please consider closing it while encouraging others to take over and reopen an issue if they care enough.
  • If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

If you are not the original author of the issue

  • If you are also experiencing this issue, please add details of your situation to help with the debugging process.
  • If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

Memorandum on closing issues

Don't be afraid to manually close an issue, even if it holds valuable information. Closed issues stay in the system for people to search, read, cross-reference, or even reopen – nothing is lost! Closing obsolete issues is an important way to help maintainers focus their time and effort.

@stale stale bot added the status: stale label Sep 28, 2024
@TheStachelfisch TheStachelfisch linked a pull request Dec 24, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rycee rycee

@sumnerevans sumnerevans

@berbiche berbiche

Labels
bug status: stale triage Issues or feature request that have not been triaged yet
Projects
None yet
Milestone
No milestone
6 participants
@rycee @Zweihander-Main @sumnerevans @berbiche @danjujan @TheStachelfisch