-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
psd: add missing module config options #5558
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I also gave it a try yesterday (danjujan@0ba5192) but you created your PR quicker 😃 .
I agree with you about leaving the USE_OVERLAYFS
and USE_SUSPSYNC
options out for now. We can still add them later if someone needs them and can test their requirements.
@rycee Can this be merged? I've been trying it out for the past few weeks and it's been working flawlessly. |
@TheStachelfisch I think the pipeline is stuck. Could you please trigger it again? |
Please, go ahead |
I do not have any permissions to trigger it. You could update your branch to run it again. |
Another bump, please have a look @rycee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this patchset, psd-resync.service
fails with mkdir: command not found
, resulting in psd
not working:
$ systemctl status --user psd-resync.service
○ psd-resync.service - Timed profile resync
Loaded: loaded (/home/<USER>/.config/systemd/user/psd-resync.service; enabled; preset: enabled)
Active: inactive (dead) since [...]
TriggeredBy: ● psd-resync.timer
Main PID: [487993] (code=exited, status=0/SUCCESS)
CPU: 7ms
[...] systemd[1789]: Starting Timed profile resync...
[...] profile-sync-daemon[488000]: /nix/store/2d2c22cr9s56ib72m88yzp80255vzpfx-profile-sync-daemon-6.50/bin/profile-sync-daemon: line 105: mkdir: command not found
[...] profile-sync-daemon[487993]: First time running psd so please edit /home/<USER>/.config/psd/psd.conf to your liking and run again.
[...] systemd[1789]: Finished Timed profile resync.
This patchset resolves this issue and allows psd
to populate its required tmpfs.
Closing in favor to creating a new pull request as the pipeline is clearly stuck and no manual feedback from someone with write access is expected. |
Description
This change adds configurable options to psd and creates the corresponding config file, it also adds missing packages to the envPath.
Previously the config file would not be automatically created, which broke psd and made it not function like it should.
I added config options that I think are relevant. I deliberately left out options like
USE_OVERLAYFS
andUSE_SUSPSYNC
as they have additional dependencies that would need to have assertions to check if they are met.Closes #5454
Checklist
Change is backwards compatible.
Code formatted with
./format
.Code tested through
nix-shell --pure tests -A run.all
ornix develop --ignore-environment .#all
using Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC
@danjujan