Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-worktree-switcher: init module #6206

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mateusauler
Copy link

Description

Create new module for git-worktree-switcher.

Note: I'm the upstream maintainer.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@jiriks74
Copy link

You can drop 4c2c109:

If you are present in the nixpkgs maintainer list then you can use that entry. If you are not then you can add yourself to modules/lib/maintainers.nix in the Home Manager project.

Copy link

@jiriks74 jiriks74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should either remove the home-manager maintainer (probably the better course of action) or use it.

modules/programs/git-worktree-switcher.nix Outdated Show resolved Hide resolved
modules/lib/maintainers.nix Outdated Show resolved Hide resolved
@mateusauler mateusauler force-pushed the gws branch 2 times, most recently from 10f961f to 7dc725a Compare December 23, 2024 15:43
@mateusauler
Copy link
Author

@jiriks74 Thank you for the review! Would you like to be added as a maintainer?

@jiriks74
Copy link

@jiriks74 Thank you for the review! Would you like to be added as a maintainer?

I would! Thanks!

@mateusauler
Copy link
Author

I would! Thanks!

Added! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants