waybar: allow setting systemd.target to null #6241
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lillecarl
suggested changes
Dec 29, 2024
modules/programs/waybar.nix
Outdated
| @@ -324,7 +324,9 @@ in { | |||
| KillMode = "mixed"; | |||
| }; | |||
|
|
|||
| Install = { WantedBy = [ cfg.systemd.target ]; }; | |||
| Install = optional (cfg.systemd.target != null) { | |||
| WantedBy = [ cfg.systemd.target ]; | |||
There was a problem hiding this comment.
This looks weird, wouldn't
Install.WantedBy = lib.optional (cfg.systemd.target != null) cfg.systemd.target;or
Install = {
WantedBy = lib.optional (cfg.systemd.target != null) cfg.systemd.target;
};Make more sense?
From noogle
"Return a singleton list or an empty list, depending on a boolean value. Useful when building lists with optional elements (e.g. ++ optional (system == "i686-linux") firefox)."
This allows making the systemd user unit appear without it autostarting, which is useful if you want to start it manually from a specific display manager config only.
flokli
force-pushed
the
waybar-opional-systemd-target
branch
from
ada312c to
c893413
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows making the systemd user unit appear without it autostarting, which is useful if you want to start it manually from a specific display manager config only.
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.allornix develop --ignore-environment .#allusing Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC
@berbiche