Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First use tweaks #125

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

First use tweaks #125

wants to merge 4 commits into from

Commits on Dec 21, 2023

  1. chore: add artifacts/ to gitignore

    @ThinkChaos
    ThinkChaos committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    e6663e0 View commit details
    Browse the repository at this point in the history

  2. fix: interpret path printed by nix as relative to repo root 

    This was causing `check` to always see the tests as new/failing, but
`review` to show a diff with no changes.
    @ThinkChaos
    ThinkChaos committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    d8bf218 View commit details
    Browse the repository at this point in the history

  3. feat(check): track test additions separately from failures 

    Tweak the output so those cases are more easily distinguishable,
especially the color used by the `+` symbol next to the test name.
Exit code is now 2 if all existing tests succeeded, but some were added.
    @ThinkChaos
    ThinkChaos committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    3d45a27 View commit details
    Browse the repository at this point in the history

  4. fix: only show flake and dir warning when relevant 

    Forgetting to set `src` was triggering it.
Ideally we'd just change the function to use `{ src, ... }@Args:` so Nix
can provide an explicit error the users are accustomed to.
    @ThinkChaos
    ThinkChaos committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    9c92de5 View commit details
    Browse the repository at this point in the history