-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add networking options. #277
Conversation
Hm, actually I might try to replicate more options from https://github.com/NixOS/nixpkgs/blob/nixos-23.05/nixos/modules/config/networking.nix , at least |
f9aa6d5
to
3776ddc
Compare
ok, seems to work. I don't really know why nixpkgs defines 127.0.0.2 as localhost, so I didn't do that :) |
It's something from nss-myhostname, but we don't have systemd so we don't really need it. |
Ping :) |
Sorry for a slow response.
|
No problem. Just wanted to make sure it's not forgotten.
I personally use only
I can try to do that. It's me who wants these settings after all :) |
So should we? :) |
On July 26, 2023 10:07:23 AM GMT+02:00, Evgeny Kurnevsky ***@***.***> wrote:
> But if we stick to it
So should we? :)
Yeah. We shouldn't invent different override mechanisms incompatible with the NixOS interface.
If you are willing to reduce it to just the subset you use and have the subset compatible, that could be a way. But I'll be willing to accept the full one + a bit of tests.
|
ok, added a test. Wanted to use https://github.com/bats-core/bats-assert#assert_line but couldn't figure out how to add it in shebang - I guess some more complex changes are required for it. |
btw, should I add myself to authors now? :) |
95c55d9
to
fe60937
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a test
good. hope grep
is available in tests.
btw, should I add myself to authors now? :)
Feel free to. My idea was to let anyone edit it when they submit a PR and think it's substantial enough. BTW, if you know where to express this idea so that all contributors get it, I'm all ears.
Also, consider adding a changelog entry.
It is.
Well, readme with or
Done. |
It seems formatting is not correct. How do I format it properly? Probably nixpkgs-fmt... There are a lot of different nix formatters :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found one typo, but otherwise it looks good to me.
Please fix that one, squash into a commit named like modules/environment/networking: implement /etc/hosts options
and let's merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you for your contribution, patience and tests!
Tested on my phone with yggdrasil - works fine :)