Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit iconOnly option for the taskmanager #410

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

thomas-bouvier
Copy link
Contributor

Hello,

I am looking for some guidance to implement an option enabling the Icons-and-Text task manager widget. At the moment, only the Icons task manager widget seems supported by this project.

I couldn't find any documentation on the matter, and this is my first Nix contribution. Looking at this file, it seems that the icons-only mode is activated when package org.kde.plasma.icontasks is used in place of org.kde.plasma.taskmanager. However, I'd like to see some validation of the robustness of this approach.

Also, the iconOnly boolean may need to be inverted to keep the default behavior to icons-only mode.

I'm currently testing to see if all the options apply to org.kde.plasma.taskmanager.

@thomas-bouvier thomas-bouvier marked this pull request as draft November 13, 2024 17:53
@HeitorAugustoLN
Copy link
Member

I guess this should fix the PR, the mkBoolOption sets a null value by default, that why the error was happening, that should do the work for taskmanager widget working. If you think it is good to go, you can mark the PR as ready for review and I would be happy to merge :)

@HeitorAugustoLN HeitorAugustoLN added 0. type: enhancement New feature or request for feature 5. first time contribution 1. scope: widgets Related to widget-specific modules 4. has: plasma widget module (update) Updates plasma widget-specific module labels Nov 25, 2024
@thomas-bouvier thomas-bouvier marked this pull request as ready for review November 26, 2024 16:10
@thomas-bouvier
Copy link
Contributor Author

Hello @HeitorAugustoLN, thank you for the fix, all is good on my side :)

@HeitorAugustoLN HeitorAugustoLN merged commit 06e3209 into nix-community:trunk Nov 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. type: enhancement New feature or request for feature 1. scope: widgets Related to widget-specific modules 4. has: plasma widget module (update) Updates plasma widget-specific module 5. first time contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants