-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable TcpMaxSeg setsockopt
option for apple targets
#2603
base: master
Are you sure you want to change the base?
Conversation
71d127f
to
8b2c4fa
Compare
changelog/2603.added.md
Outdated
@@ -0,0 +1 @@ | |||
Added the TcpMaxSeg socket option for apple targets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this socket option was available for macOS, but for getsockopt() only. This PR adds the setsockopt()
part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, right you are. Fixed.
Could you please give this test an update as well? Lines 161 to 221 in 003bfe4
|
8b2c4fa
to
4c4aa25
Compare
4c4aa25
to
4565854
Compare
setsockopt
option for apple targets
@SteveLauC I updated the test. Had to change it around a bit though since it seems MaxSeg works slightly differently on macos:
Still I hope the test is good enough :) |
What does this PR do
Enables the TcpMaxSeg socket option for apple targets. I've tested this on MacOS, not sure about iOS but I imagine it would work just the same.
Here's some code I used to verify that it works:
Checklist:
CONTRIBUTING.md