Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add create table #144

Closed
wants to merge 2 commits into from
Closed

add create table #144

wants to merge 2 commits into from

Conversation

chaseWillden
Copy link
Collaborator

Adds the ability to create tables via code:

let result = sqlite::create::create_table(c, User::default()).build();

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
njord ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 2:13pm

@mjovanc
Copy link
Member

mjovanc commented Oct 8, 2024

I think we should use this in our njord_cli binary project instead to handle the migrations and just use njord library to map to what exists in the db though. I was thinking this initially as well, but I'm not seeing this as an important feature. But I might be wrong here! Let me know what you think. I already started the project of the CLI but waited with it since I wanted to build the more essential parts first.

@chaseWillden
Copy link
Collaborator Author

I think we should use this in our njord_cli binary project instead to handle the migrations and just use njord library to map to what exists in the db though. I was thinking this initially as well, but I'm not seeing this as an important feature. But I might be wrong here! Let me know what you think. I already started the project of the CLI but waited with it since I wanted to build the more essential parts first.

The main reason why I was building this in was because I had to go into the select_into.db file and actually do the create table stuff. It was more of a convenience. As far as the cli, totally agree there. This was one feature we would always use in the Jetbrains Exposed ORM as we were building new apps. I'm honestly cool either way though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants