Merge pull request #76 from njoy/fix/pybinf11-default-ctors

Fix/pybinf11 default ctors

src/scion/math/ChebyshevApproximation/src/ctor.hpp

@@ -1,3 +1,8 @@
+/**
+ *  @brief Default constructor (for pybind11 purposes only)
+ */
+ChebyshevApproximation() = default;
+
 /**
  *  @brief Constructor
  *

src/scion/math/ChebyshevSeries/src/ctor.hpp

@@ -1,3 +1,8 @@
+/**
+ *  @brief Default constructor (for pybind11 purposes only)
+ */
+ChebyshevSeries() = default;
+
 /**
  *  @brief Constructor
  *

src/scion/math/ChebyshevSeries/test/ChebyshevSeries.test.cpp

@@ -458,7 +458,8 @@ SCENARIO( "ChebyshevSeries" ) {
 
       THEN( "an exception is thrown" ) {
 
-        CHECK_THROWS( ChebyshevSeries< double >( {} ) );
+        std::vector< double > empty = {};
+        CHECK_THROWS( ChebyshevSeries< double >( empty ) );
       } // THEN
     } // WHEN
   } // GIVEN

src/scion/math/InterpolationTable/src/ctor.hpp

@@ -1,3 +1,8 @@
+/**
+ *  @brief Default constructor (for pybind11 purposes only)
+ */
+InterpolationTable() = default;
+
 /**
  *  @brief Copy constructor
  *

src/scion/math/InterpolationTable/src/evaluateOnGrid.hpp

@@ -5,6 +5,7 @@ std::vector< Y > evaluateOnGrid( const std::vector< X >& x ) const {
   auto xIter = std::lower_bound( x.begin(), x.end(), this->x().front() );
   if ( *std::next( xIter ) == this->x().front() ) {
 
+    // move to the next x value in case of a jump
     ++xIter;
   }
   auto yIter = std::next( y.begin(), std::distance( x.begin(), xIter ) );

src/scion/math/InterpolationTableFunction/src/ctor.hpp

@@ -1,3 +1,8 @@
+/**
+ *  @brief Default constructor (for pybind11 purposes only)
+ */
+InterpolationTableFunction() = default;
+
 /**
  *  @brief Copy constructor
  *

src/scion/math/LegendreSeries/src/ctor.hpp

@@ -1,3 +1,8 @@
+/**
+ *  @brief Default constructor (for pybind11 purposes only)
+ */
+LegendreSeries() = default;
+
 /**
  *  @brief Constructor
  *

src/scion/math/LegendreSeries/test/LegendreSeries.test.cpp

@@ -458,7 +458,8 @@ SCENARIO( "LegendreSeries" ) {
 
       THEN( "an exception is thrown" ) {
 
-        CHECK_THROWS( LegendreSeries< double >( {} ) );
+        std::vector< double > empty = {};
+        CHECK_THROWS( LegendreSeries< double >( empty ) );
       } // THEN
     } // WHEN
   } // GIVEN

src/scion/math/OneDimensionalFunctionBase.hpp

@@ -41,6 +41,11 @@ namespace math {
 
     /* constructor */
 
+    /**
+     *  @brief Default constructor (for pybind11 purposes only)
+     */
+    OneDimensionalFunctionBase() = default;
+
     /**
      *  @brief Constructor
      *
@@ -54,10 +59,8 @@ namespace math {
     /* methods */
 
     /**
-     *  @brief Check whether or not a value is inside the domain (including
-     *         boundaries)
-     *
-     *  @param x   the value to be tested
+     *  @brief Return the domain of the function (either an open or interval
+     *         domain)
      */
     const DomainVariant& domain() const noexcept {
 

src/scion/math/PolynomialSeries/src/ctor.hpp

@@ -1,3 +1,8 @@
+/**
+ *  @brief Default constructor (for pybind11 purposes only)
+ */
+PolynomialSeries() = default;
+
 /**
  *  @brief Constructor
  *

src/scion/math/PolynomialSeries/test/PolynomialSeries.test.cpp

@@ -473,7 +473,8 @@ SCENARIO( "PolynomialSeries" ) {
 
       THEN( "an exception is thrown" ) {
 
-        CHECK_THROWS( PolynomialSeries< double >( {} ) );
+        std::vector< double > empty = {};
+        CHECK_THROWS( PolynomialSeries< double >( empty ) );
       } // THEN
     } // WHEN
   } // GIVEN

src/scion/math/SeriesBase/src/ctor.hpp

@@ -1,3 +1,8 @@
+/**
+ *  @brief Default constructor (for pybind11 purposes only)
+ */
+SeriesBase() = default;
+
 /**
  *  @brief Constructor
  *

src/scion/unionisation/unionise.hpp

@@ -14,8 +14,8 @@ namespace unionisation {
    *  @brief Unionise two grids and preserve duplicate points that appear in each
    *
    *  If the grids do not have the same begin and/or end point, a duplicate point
-   *  is inserted into the grid corresponding to the highest begining and/or
-   *  lowest end point (unless those is already a duplicate point).
+   *  is inserted into the grid corresponding to the highest beginning and/or
+   *  lowest end point (unless those are already a duplicate point).
    *
    *  @param first        the first grid (assumed to be sorted)
    *  @param second       the second grid (assumed to be sorted)