Add 白讀 to gwongzau.js #31
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! But this seems incomplete? |
|
Ah, you are right, I apologize! I forgot to push a few changes before I made this PR. I'll do so soon. |
untunt
force-pushed
the
main
branch
3 times, most recently
from
a50f6d6
to
1769033
Compare
untunt
force-pushed
the
main
branch
2 times, most recently
from
939681c
to
fc24966
Compare
untunt
force-pushed
the
main
branch
2 times, most recently
from
6b51961
to
62b1074
Compare
untunt
force-pushed
the
main
branch
5 times, most recently
from
07d7fdd
to
b4b5a19
Compare
307587
reviewed
May 10, 2024
| @@ -241,6 +273,11 @@ let 聲調 = 聲調規則(); | |||
| const is細音 = ['eo', 'i', 'oe', 'u', 'yu'].some((x) => 韻母.startsWith(x)); | |||
| if (聲母 === 'ng' && is細音) 聲母 = 'j'; | |||
|
|
|||
| if (選項.文白讀 === '白讀') { | |||
|
第276行有少少問題，白讀咁推會推埋落曾攝，但曾攝無咁樣白讀法，咁寫會將曾攝推錯音。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
gwongzau.jsonly generates 文讀. Gwongzau 白讀 readings are also generally predictable from Middle Chinese readings, and so can be added as an option.