Implement 音韻地位.合法性 #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
已跑过《广韵》的所有小韵验证 |
ayaka14732
reviewed
Jul 10, 2021
Using IntEnum now Co-authored-by: Ayaka Mikazuki <[email protected]>
syimyuzya
approved these changes
Jul 10, 2021
ayaka14732
reviewed
Jul 10, 2021
commit 64fd85c Author: Ayaka Mikazuki <[email protected]> Date: Sat Jul 10 17:07:19 2021 +0800 Fix bug commit e46cb11 Author: Ayaka Mikazuki <[email protected]> Date: Sat Jul 10 17:00:06 2021 +0800 Fix bug commit 935450d Author: Ayaka Mikazuki <[email protected]> Date: Sat Jul 10 16:57:32 2021 +0800 Fix bug commit 8bf6baa Author: Ayaka Mikazuki <[email protected]> Date: Sat Jul 10 16:56:20 2021 +0800 Support Python 3.10 and drop support of Python 3.6
|
最低 Python 版本改成 3.7 了，現在 typing 應該沒問題了 |
|
@ayaka14732 注释加上啦 |
|
我累死了 |
syimyuzya
approved these changes
Jul 10, 2021
ayaka14732
requested changes
Jul 11, 2021
src/QieyunEncoder/音韻地位.py
Outdated
Comment on lines
624
to
632
| 合法性分爲 6 類，分別是： | ||
| - 無效：聲母和韻母的固有性質互相衝突，無法拼合的情況。如：徹母齊韻、昌母山韻 | ||
| - 強非法：範圍廣（> 50 個音節）且例外少（< 4%）的音系規則所禁止的情況。如：廢韻上聲、銳音四等合口 | ||
| - 弱非法：範圍小（≤ 50 個音節）或例外多（4% ~ 15%）的音系規則所禁止的情況。如：來母二等、銳音痕韻 | ||
| - 弱合法：語音學上沒有明確的約束，但範圍內有字率低于 15% 且都是僻字的情況。如：蒸合舒聲、東三上聲 | ||
| - 稀有合法：語音學上沒有明確的約束，但範圍內有字率低于 15% 而不都是僻字的情況。如：云母鍾韻、知組銜韻 | ||
| - 強合法：其餘情況。強合法音節的平均有字率約爲 75% | ||
|
|
||
| 非法音節的空缺是系统空缺（systematic gap），非法音節範圍內的字屬於边缘音节。合法音節的空缺是偶然空缺（accidental gap）。 |
There was a problem hiding this comment.
Move to the documentation of class 合法性
There was a problem hiding this comment.
Are we going to export 合法性等級, without actual usage in the API? (as 音韻地位.合法性() only returns its str form)
if not, how do we include it in the docs?
My suggestion: Would it be better if we add a link in the doc of 合法性等級 mentioning 音韻地位.合法性() instead, showing that it is an implementation detail of the public method?
Co-authored-by: Ayaka Mikazuki <[email protected]>
Co-authored-by: Ayaka Mikazuki <[email protected]>
syimyuzya
requested changes
Jul 11, 2021
列表前空一行（否則文檔生成工具 pdoc3 不認識這是列表） Co-authored-by: Sekai Zhou <[email protected]>
syimyuzya
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.