Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

老國音 #60

Open
wants to merge 76 commits into
base: main
Choose a base branch
from
Open

老國音 #60

wants to merge 76 commits into from

Conversation

307587
Copy link

@307587 307587 commented Sep 9, 2024

未完成

@syimyuzya
Copy link
Member

  • 未完成,應該用 draft 而非 open 狀態
  • 列出的三項參考資料,僅第二項 rime-bepemefeve 宜作參考,而第一項 Old-National-Pronunciation 不完整,第三項 lau_guoq_in 是「偽老國音」

※ 關於「偽老國音」請參:https://www.bilibili.com/read/cv17377530/

@syimyuzya syimyuzya marked this pull request as draft October 8, 2024 08:27
@syimyuzya syimyuzya mentioned this pull request Oct 8, 2024
@307587
Copy link
Author

307587 commented Oct 24, 2024

爲什麼要改上面「攷」部份的連結?WV條目有什麼問題?那版本的推導器不是廢了嗎?

@syimyuzya syimyuzya mentioned this pull request Oct 25, 2024
@307587 307587 mentioned this pull request Jan 29, 2025
@graphemecluster
Copy link
Member

graphemecluster commented Jan 29, 2025

我想你不懂怎麼 resolve conflict,我幫你處理了,但在我們再次接受 review 之前,你還需要執行命令 fix 好 lint 問題以通過 CI check,以及仔細閲讀每一個 comment 並妥善處置好過往所有 review

@graphemecluster graphemecluster removed their request for review January 29, 2025 23:18
@307587
Copy link
Author

307587 commented Jan 30, 2025

sorry我只是按錯了

老國音.js Outdated
[`注音符號
否的話就用國際音標`, true], //完
['注音符號省略陰平調號', false, {hidden: 選項.注音符號 !== true}], //完
選項.注音符號 !== true ? '音標風格' : undefined,
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@graphemecluster 這和你建議的...(選項.注音符號 !== false ? [/* ... */] : [])有什麼不同?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

就是不用罰抄十次 { hidden: 選項.注音符號 !== true } 的分別

@307587
Copy link
Author

307587 commented Feb 7, 2025

屌,又手殘按錯,sorry @graphemecluster

@graphemecluster graphemecluster removed their request for review February 8, 2025 04:39
@graphemecluster
Copy link
Member

嗱,你自己小心狼來了啊

@307587
Copy link
Author

307587 commented Feb 23, 2025

@untunt ㄭ音要不要也加[ɨ]的寫法?

@untunt
Copy link
Member

untunt commented Feb 24, 2025

不要。根本没有 [ɨ] 的读音

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants