checkVisibility comparison fixes #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checkVisibility must not be compared against zero because checkVisibility won't return zero when intersecting with vision blocking particles, a very very tiny number is returned instead
|
Thank you for the continued pull requests. Currently all authors are really busy with their real lives hence why things are slow |
|
Great stuff! |
nk3nny
approved these changes
Feb 19, 2024
|
This was a little delayed in getting approved simply because I wanted to play around about with the logic itself. I think you are on to something on how building positions should be cleared. When testing this was done in a rather sterile environment, without any smoke disrupting LOS. I wonder if we want them to check extra carefully (not just disregard corners) as currently when there is smoke. Regardless. This is good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: Remove all instances of
checkVisibilitybeing compared against zerocheckVisibilitywill not return zero in case of vision blocking particles. With this PR,checkVisibilityis compared against0.01instead. I have arbitrarily chosen 1% to be the visibility threshold, feel free to suggest otherwise.