Improvements to taskGarrison and taskCamp #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds garrisoned units that are placed outside will appear to look out from building Improves garrison behaviour when there are no outdoor locations (fixes issue #413) Fixes units being teleported to building positions located in air Fixes taskCamp units sometimes throwing double animation resets Fixes taskCamp units failing to reset animations -- Prefers using setVehiclePosition rather than setPos when placing units. While more expensive, taskGarrison and taskCamp are not run frequently. This neatly fixes many issues where units were spawned in the air (and fell to their deaths!) With the new and improved eventhandlers reseting animations in taskCampReset is much more reliable. Therefore no need to run the function multiple times on all units.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds garrisoned units that are placed outside will appear to look out from building
Improves garrison behaviour when there are no indoor locations (fixes issue #413)
Fixes units being teleported to building positions located in air
Fixes taskCamp units sometimes throwing double animation resets
Fixes taskCamp units failing to reset animations
--
Prefers using setVehiclePosition rather than setPos when placing units. While more expensive, taskGarrison and taskCamp are not run frequently. This neatly fixes many issues where units were spawned in the air (and fell to their deaths!)
With the new and improved eventhandlers makes resetting animations in taskCampReset is much more reliable. Therefore no need to run the function multiple times on all units.