Skip to content

Commit

Permalink
Use "m-io" instead of "q-io" to avoid wrongly implemented "Array.prot…
Browse files Browse the repository at this point in the history
…otype.find"

This method is injected in the `collections`-package as array-shim, which is a dependency of q-io.
Version 1.x of `collections` implements the method with the semantics of `Array.prototype.findIndex`
instead. This leads to problems with other packages that rely on the implementation as defined in the ES6-Standard
See also: https://github.com/montagejs/collections/issues/139Use q-io@2 to exclude wrongly implemented
"Array.prototype.find"-method This method is injected in the `collections`-package as array-shim, which is a dependency
of q-io. Version 1.x of `collections` implements the method with the semantics of `Array.prototype.findIndex` instead.
This leads to problems with other packages that rely on the implementation as defined in the ES6-Standard See also:
montagejs/collections#139

Zeilen,
  • Loading branch information
nknapp committed Jul 22, 2016
1 parent f392e8f commit 15e5fd5
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion lib/changelog.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
*/
'use strict'

var qfs = require('q-io/fs')
var qfs = require('m-io/fs')
var path = require('path')
var qcp = require('../lib/q-child-process.js')

Expand Down
2 changes: 1 addition & 1 deletion lib/git.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
'use strict'

var cpp = require('../lib/q-child-process')
var qfs = require('q-io/fs')
var qfs = require('m-io/fs')
var path = require('path')
var moment = require('moment')
var debug = require('debug')('thoughtful-release:git')
Expand Down
2 changes: 1 addition & 1 deletion lib/npm.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

var path = require('path')
var semver = require('semver')
var qfs = require('q-io/fs')
var qfs = require('m-io/fs')
var Q = require('q')
var _ = {
defaultsDeep: require('lodash.defaultsdeep')
Expand Down
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,10 @@
"lodash.isplainobject": "^3",
"lodash.isstring": "^3.0.1",
"lodash.toarray": "^3.0.2",
"m-io": "*",
"mkdirp": "^0.5.1",
"moment": "^2.11.1",
"q": "^1.4.1",
"q-io": "^2.0.6",
"semver": "^5.1.0"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion test/changelog-spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ var chaiAsPromised = require('chai-as-promised')
chai.use(chaiAsPromised)
var expect = chai.expect
var changelog = require('../lib/changelog.js')
var qfs = require('q-io/fs')
var qfs = require('m-io/fs')
var path = require('path')
require('./trace')

Expand Down
2 changes: 1 addition & 1 deletion test/git-spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ var chaiAsPromised = require('chai-as-promised')
chai.use(chaiAsPromised)
var expect = chai.expect
var git = require('../lib/git.js')
var qfs = require('q-io/fs')
var qfs = require('m-io/fs')
var Q = require('q')
var path = require('path')
require('./trace')
Expand Down
2 changes: 1 addition & 1 deletion test/index-spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ var chaiAsPromised = require('chai-as-promised')
chai.use(chaiAsPromised)
var expect = chai.expect
var qcp = require('../lib/q-child-process')
var qfs = require('q-io/fs')
var qfs = require('m-io/fs')
var path = require('path')
var Q = require('q')
var _ = {
Expand Down
Empty file added test/test.js
Empty file.

0 comments on commit 15e5fd5

Please sign in to comment.