Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use q-io@2 to exclude wrongly implemented "Array.prototype.find"-method #6

Closed
wants to merge 4 commits into from
Closed

Use q-io@2 to exclude wrongly implemented "Array.prototype.find"-method #6

wants to merge 4 commits into from

Commits on Jul 22, 2016

  1. Use q-io@2 to exclude wrongly implemented "Array.prototype.find"-method 

    This method is injected in the `collections`-package as array-shim, which is a dependency of q-io.
Version 1.x of `collections` implements the method with the semantics of `Array.prototype.findIndex`
instead. This leads to problems with other packages that rely on the implementation as defined in the ES6-Standard  See also: https://github.com/montagejs/collections/issues/139Use q-io@2 to exclude wrongly implemented "Array.prototype.find"-method  This method is injected in the `collections`-package as array-shim, which is a dependency of q-io. Version 1.x of `collections` implements the method with the semantics of `Array.prototype.findIndex` instead. This leads to problems with other packages that rely on the implementation as defined in the ES6-Standard  See also: montagejs/collections#139
    @nknapp
    nknapp committed Jul 22, 2016
    Configuration menu
    Copy the full SHA
    f84b188 View commit details
    Browse the repository at this point in the history

  2. Apply trace-package only in node 6 (incompatible with 4)

    @nknapp
    nknapp committed Jul 22, 2016
    Configuration menu
    Copy the full SHA
    f392e8f View commit details
    Browse the repository at this point in the history

  3. Use "m-io" instead of "q-io" to avoid wrongly implemented "Array.prot… 

    …otype.find"

This method is injected in the `collections`-package as array-shim, which is a dependency of q-io.
Version 1.x of `collections` implements the method with the semantics of `Array.prototype.findIndex`
instead. This leads to problems with other packages that rely on the implementation as defined in the ES6-Standard
See also: https://github.com/montagejs/collections/issues/139Use q-io@2 to exclude wrongly implemented
"Array.prototype.find"-method This method is injected in the `collections`-package as array-shim, which is a dependency
of q-io. Version 1.x of `collections` implements the method with the semantics of `Array.prototype.findIndex` instead.
This leads to problems with other packages that rely on the implementation as defined in the ES6-Standard See also:
montagejs/collections#139

Zeilen,
    @nknapp
    nknapp committed Jul 22, 2016
    Configuration menu
    Copy the full SHA
    15e5fd5 View commit details
    Browse the repository at this point in the history

  4. Add node 6 to travis and appveyor build

    @nknapp
    nknapp committed Jul 22, 2016
    Configuration menu
    Copy the full SHA
    9dd4e6f View commit details
    Browse the repository at this point in the history