Remove Baseprops (#1382)

* feat: removed BaseProps * feat: removed BaseDataDisplay * fix: build * fix: build issues * fix: build * fix: build * fix: build --------- Co-authored-by: YourivHDenHaag <[email protected]>
nl-design-system · Nov 9, 2023 · be4693c · be4693c · vercel · Nov 9, 2023
1 parent bf169e0
commit be4693c
Show file tree

Hide file tree

Showing 67 changed files with 155 additions and 447 deletions.
diff --git a/components/Accordion/tsconfig.json b/components/Accordion/tsconfig.json
@@ -13,9 +13,6 @@
     },
     {
       "path": "../Typography"
-    },
-    {
-      "path": "../BaseProps"
     }
   ]
 }
diff --git a/components/Action/tsconfig.json b/components/Action/tsconfig.json
@@ -11,9 +11,6 @@
     {
       "path": "../Icons"
     },
-    {
-      "path": "../BaseProps"
-    },
     {
       "path": "../../proprietary/Common"
     },

diff --git a/components/Alert/package.json b/components/Alert/package.json
@@ -29,7 +29,6 @@
     "clean": "rimraf dist tsconfig.tsbuildinfo"
   },
   "dependencies": {
-    "@gemeente-denhaag/baseprops": "workspace:*",
     "@gemeente-denhaag/button": "workspace:*",
     "@gemeente-denhaag/iconbutton": "workspace:*",
     "@gemeente-denhaag/icons": "workspace:*",

diff --git a/components/Alert/src/index.tsx b/components/Alert/src/index.tsx
@@ -1,5 +1,4 @@
 import React from 'react';
-import BaseProps from '@gemeente-denhaag/baseprops';
 import Button from '@gemeente-denhaag/button';
 import { Heading4, Paragraph } from '@gemeente-denhaag/typography';
 import { AlertTriangleIcon, CheckCircleIcon, CircleInformationIcon, CloseIcon } from '@gemeente-denhaag/icons';
@@ -8,7 +7,15 @@ import IconButton from '@gemeente-denhaag/iconbutton';
 import './index.scss';
 import clsx from 'clsx';
 
-export interface AlertProps extends Omit<BaseProps, 'children' | 'classes' | 'tabIndex'> {
+export interface AlertProps {
+  /**
+   * The id attribute is used to specify a unique id for an HTML element.
+   */
+  id?: string;
+  /**
+   * Extend the styles of the component by adding new classes.
+   */
+  className?: string;
   /**
    * The title of the alert.
    */

diff --git a/components/Alert/tsconfig.json b/components/Alert/tsconfig.json
@@ -8,9 +8,6 @@
   "include": ["src/**/*"],
   "exclude": ["dist", "src/**/*.stories.tsx"],
   "references": [
-    {
-      "path": "../BaseProps"
-    },
     {
       "path": "../Icons"
     },

diff --git a/components/BadgeCounter/tsconfig.json b/components/BadgeCounter/tsconfig.json
@@ -10,9 +10,6 @@
   "references": [
     {
       "path": "../DotIndicator"
-    },
-    {
-      "path": "../BaseDataDisplayProps"
     }
   ]
 }
diff --git a/components/BaseDataDisplayProps/package.json b/components/BaseDataDisplayProps/package.json
diff --git a/components/BaseDataDisplayProps/src/index.tsx b/components/BaseDataDisplayProps/src/index.tsx
diff --git a/components/BaseDataDisplayProps/tsconfig.json b/components/BaseDataDisplayProps/tsconfig.json
diff --git a/components/BaseProps/package.json b/components/BaseProps/package.json
diff --git a/components/BaseProps/src/index.tsx b/components/BaseProps/src/index.tsx
diff --git a/components/BaseProps/tsconfig.json b/components/BaseProps/tsconfig.json
diff --git a/components/Breadcrumb/src/index.tsx b/components/Breadcrumb/src/index.tsx
@@ -1,5 +1,4 @@
 import React from 'react';
-import BaseProps from '@gemeente-denhaag/baseprops';
 import ResponsiveContent from '@gemeente-denhaag/responsive-content';
 import { ChevronRightIcon, HouseIcon } from '@gemeente-denhaag/icons';
 import { CustomLink } from '@gemeente-denhaag/link';
@@ -16,7 +15,7 @@ export interface BreadcrumbItemData {
   href?: string;
 }
 
-export interface BreadcrumbProps extends Omit<BaseProps, 'tabIndex' | 'classNames'> {
+export interface BreadcrumbProps {
   /**
    * The navigation path array of JSON object, which includes a label and url.
    */

diff --git a/components/Breadcrumb/tsconfig.json b/components/Breadcrumb/tsconfig.json
@@ -11,9 +11,6 @@
     {
       "path": "../Icons"
     },
-    {
-      "path": "../BaseProps"
-    },
     {
       "path": "../../proprietary/Common"
     },

diff --git a/components/Button/package.json b/components/Button/package.json
@@ -29,9 +29,6 @@
   },
   "bugs": "https://github.com/nl-design-system/denhaag/issues",
   "dependencies": {
-    "@gemeente-denhaag/baseprops": "workspace:*"
-  },
-  "devDependencies": {
     "@gemeente-denhaag/icons": "workspace:*"
   },
   "peerDependencies": {

diff --git a/components/Button/tsconfig.json b/components/Button/tsconfig.json
@@ -11,9 +11,6 @@
     {
       "path": "../Icons"
     },
-    {
-      "path": "../BaseProps"
-    },
     {
       "path": "../../proprietary/Common"
     },

diff --git a/components/ButtonGroup/tsconfig.json b/components/ButtonGroup/tsconfig.json
@@ -11,9 +11,6 @@
     {
       "path": "../Icons"
     },
-    {
-      "path": "../BaseProps"
-    },
     {
       "path": "../../proprietary/Common"
     },

diff --git a/components/Card/tsconfig.json b/components/Card/tsconfig.json
@@ -10,9 +10,6 @@
   "references": [
     {
       "path": "../Icons"
-    },
-    {
-      "path": "../BaseProps"
     }
   ]
 }
diff --git a/components/Checkbox/tsconfig.json b/components/Checkbox/tsconfig.json
@@ -8,9 +8,6 @@
   "include": ["src/**/*"],
   "exclude": ["dist", "src/**/*.stories.tsx"],
   "references": [
-    {
-      "path": "../BaseProps"
-    },
     {
       "path": "../FormControlLabel"
     },

diff --git a/components/CtaEvent/tsconfig.json b/components/CtaEvent/tsconfig.json
@@ -7,9 +7,5 @@
   },
   "include": ["src/**/*"],
   "exclude": ["dist", "src/**/*.stories.tsx"],
-  "references": [
-    {
-      "path": "../BaseProps"
-    }
-  ]
+  "references": []
 }
diff --git a/components/Divider/package.json b/components/Divider/package.json
@@ -29,14 +29,10 @@
     "clean": "rimraf dist tsconfig.tsbuildinfo"
   },
   "dependencies": {
-    "@gemeente-denhaag/basedatadisplayprops": "workspace:*",
-    "@gemeente-denhaag/baseprops": "workspace:*"
+    "@gemeente-denhaag/icons": "workspace:*"
   },
   "peerDependencies": {
     "react": "^17.0.0 || ^18.0.0"
   },
-  "devDependencies": {
-    "@gemeente-denhaag/icons": "workspace:*"
-  },
   "gitHead": "dcf72a9b79266c1ebede35aff4a02dd9121a980f"
 }
diff --git a/components/Divider/src/index.tsx b/components/Divider/src/index.tsx
@@ -1,6 +1,6 @@
 import React from 'react';
-import './index.scss';
 import clsx from 'clsx';
+import './index.scss';
 
 export interface DividerProps extends React.HTMLAttributes<HTMLHRElement> {
   /**

diff --git a/components/Divider/tsconfig.json b/components/Divider/tsconfig.json
@@ -11,9 +11,6 @@
     {
       "path": "../Icons"
     },
-    {
-      "path": "../BaseDataDisplayProps"
-    },
     {
       "path": "../../proprietary/Components"
     },

diff --git a/components/DotIndicator/package.json b/components/DotIndicator/package.json
@@ -29,9 +29,6 @@
     "clean": "rimraf dist tsconfig.tsbuildinfo"
   },
   "dependencies": {
-    "@gemeente-denhaag/baseprops": "workspace:*"
-  },
-  "devDependencies": {
     "@gemeente-denhaag/button": "workspace:*"
   },
   "peerDependencies": {
-Original file line number
+Diff line change
@@ Expand Up / @@ -13,9 +13,6 @@ @@
         },
         {
           "path": "../Typography"
-        },
-        {
-          "path": "../BaseProps"
         }
       ]
     }