feat: combobox React package #2453

AliKdhim87 · 2024-08-30T15:14:47Z

No description provided.

vercel · 2024-08-30T15:14:50Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
utrecht	❌ Failed (Inspect)			Sep 17, 2024 0:07am

codecov · 2024-09-05T09:33:37Z

Codecov Report

Attention: Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.19%. Comparing base (2e398a8) to head (70d3654).

Files with missing lines	Patch %	Lines
...ages/components-react/combobox-react/src/index.tsx	96.96%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2453      +/-   ##
==========================================
+ Coverage   93.98%   94.19%   +0.21%     
==========================================
  Files         157      158       +1     
  Lines        1313     1344      +31     
  Branches      287      305      +18     
==========================================
+ Hits         1234     1266      +32     
+ Misses         78       74       -4     
- Partials        1        4       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Robbert

Dit is nog een pending review van vorige week, ik ga nog opnieuw kijken naar je nieuwe code.

Robbert · 2024-09-03T08:15:41Z

.changeset/afraid-bugs-taste.md

@@ -0,0 +1,5 @@
+---
+"@utrecht/listbox-react": minor


Het is handiger om nieuwe packages te beginnen met 0.0.0 en dan een major release.

Robbert · 2024-09-03T08:16:12Z

.changeset/cuddly-balloons-ring.md

+"@utrecht/calendar-react": patch
+---
+
+Fix the button style issue when importe it from `dist/css-module`


Suggested change

Fix the button style issue when importe it from `dist/css-module`

Fix the button style issue when importing it from `dist/css-module`.

Robbert · 2024-09-03T08:17:40Z

.changeset/shaggy-tables-sort.md

+"@utrecht/storybook-react": patch
+---
+
+Fix the Textbox component import


Storybook doen we geen releases van, hoeft geen changeset te hebben.

Robbert · 2024-09-03T08:21:25Z

packages/storybook-react/src/stories/Textbox.stories.tsx

@@ -1,5 +1,5 @@
 import { Meta, StoryObj } from '@storybook/react';
-import { Textbox } from '@utrecht/component-library-react/dist/css-module/index';
+import { Textbox } from '@utrecht/component-library-react/dist/css-module';


In ES modules moet je expliciet de filename noemen zoals het was, dus ik zou de import path zo expliciet mogelijk maken, dan is het makkelijker om uiteindelijk naar die syntax over te gaan.

Robbert · 2024-09-03T08:27:20Z

packages/component-library-react/packages/textbox-react/package.json

@@ -0,0 +1,41 @@
+{
+  "version": "1.0.0",


Suggested change

"version": "1.0.0",

"version": "0.0.0",

Robbert · 2024-09-03T08:28:00Z

packages/component-library-react/packages/textbox-react/package.json

+{
+  "version": "1.0.0",
+  "author": "Community for NL Design System",
+  "description": "Button component for the Municipality of Utrecht based on the NL Design System architecture",


Suggested change

"description": "Button component for the Municipality of Utrecht based on the NL Design System architecture",

"description": "Textbox component for the Municipality of Utrecht based on the NL Design System architecture",

Robbert · 2024-10-18T08:26:31Z

.github/workflows/continuous-delivery.yml

-
+      - name: "Continuous Integration: build"
+        run: |
+          pnpm run --if-present build


The new classes: - `utrecht-combobox__textbox-container` - `utrecht-combobox__toggle-button` ```CSS --utrecht-combobox-toggle-button-background-color: transparent; //default value --utrecht-combobox-toggle-button-color: currentColor; //default value --utrecht-combobox-toggle-button-hover-background-color: transparent; //default value --utrecht-combobox-toggle-button-hover-color: currentColor; //default value --utrecht-combobox-toggle-button-active-background-color: transparent; //default value --utrecht-combobox-toggle-button-active-color: currentColor; //default value --utrecht-combobox-toggle-button-focus-background-color: transparent; //default value --utrecht-combobox-toggle-button-focus-color: currentColor; //default value --utrecht-combobox-toggle-button-pressed-background-color: transparent; //default value --utrecht-combobox-toggle-button-pressed-color: currentColor; //default value ``` - `utrecht-combobox__icon` ```CSS --utrecht-combobox-icon-size: 32px; //default value ```

vercel bot had a problem deploying to Preview August 30, 2024 15:19 Failure

Robbert changed the title ~~wip~~ feat: combobox React package Aug 31, 2024

AliKdhim87 force-pushed the feat/create-comboxbox branch from d2efe5d to 872d072 Compare September 2, 2024 11:03

AliKdhim87 requested a review from Robbert September 2, 2024 11:03

vercel bot deployed to Preview September 2, 2024 11:13 View deployment

AliKdhim87 force-pushed the feat/create-comboxbox branch from 872d072 to c760ff4 Compare September 2, 2024 11:38

vercel bot deployed to Preview September 2, 2024 11:48 View deployment

AliKdhim87 force-pushed the feat/create-comboxbox branch 3 times, most recently from 970c5b9 to e33e4bb Compare September 2, 2024 14:48

AliKdhim87 linked an issue Sep 2, 2024 that may be closed by this pull request

Product-metadata heeft select-component om Uniforme Productnaam te kiezen frameless/strapi#801

Open

5 tasks

vercel bot deployed to Preview September 2, 2024 15:03 View deployment

AliKdhim87 force-pushed the feat/create-comboxbox branch from e33e4bb to 6961829 Compare September 3, 2024 07:18

vercel bot deployed to Preview September 3, 2024 07:38 View deployment

AliKdhim87 force-pushed the feat/create-comboxbox branch from 6961829 to 76ca25d Compare September 3, 2024 07:48

vercel bot had a problem deploying to Preview September 3, 2024 07:58 Failure

AliKdhim87 force-pushed the feat/create-comboxbox branch 3 times, most recently from a72fc77 to aa33062 Compare September 3, 2024 12:06

AliKdhim87 marked this pull request as ready for review September 3, 2024 12:07

vercel bot had a problem deploying to Preview September 3, 2024 12:14 Failure

AliKdhim87 force-pushed the feat/create-comboxbox branch 2 times, most recently from c884c8c to 1be5184 Compare September 3, 2024 12:28

vercel bot had a problem deploying to Preview September 3, 2024 12:44 Failure

vercel bot had a problem deploying to Preview September 3, 2024 15:22 Failure

vercel bot deployed to Preview September 4, 2024 09:56 View deployment

AliKdhim87 force-pushed the feat/create-comboxbox branch from 619347a to cc8e392 Compare September 4, 2024 12:02

vercel bot deployed to Preview September 5, 2024 09:33 View deployment

AliKdhim87 force-pushed the feat/create-comboxbox branch from cb92447 to 1844694 Compare September 5, 2024 10:07

vercel bot had a problem deploying to Preview September 5, 2024 10:26 Failure

Robbert reviewed Sep 10, 2024

View reviewed changes

AliKdhim87 force-pushed the feat/create-comboxbox branch 6 times, most recently from 2c3eed6 to 2cafdd6 Compare September 10, 2024 11:54

vercel bot had a problem deploying to Preview September 10, 2024 12:05 Failure

AliKdhim87 force-pushed the feat/create-comboxbox branch 4 times, most recently from 72e7b01 to d9d9250 Compare September 10, 2024 12:26

vercel bot deployed to Preview September 10, 2024 12:37 View deployment

AliKdhim87 force-pushed the feat/create-comboxbox branch from d9d9250 to 0d34140 Compare September 17, 2024 11:56

vercel bot had a problem deploying to Preview September 17, 2024 12:07 Failure

AliKdhim87 requested a review from Robbert September 18, 2024 08:21

Robbert reviewed Oct 18, 2024

View reviewed changes

.github/workflows/continuous-delivery.yml Outdated

- name: "Continuous Integration: build"

run: |

pnpm run --if-present build

Copy link

Member

Robbert Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

AliKdhim87 added 2 commits October 29, 2024 11:40

fix: fix the listbox width on small screens

efd02a5

AliKdhim87 force-pushed the feat/create-comboxbox branch from 0d34140 to c709b71 Compare October 29, 2024 13:07

AliKdhim87 added 6 commits October 29, 2024 14:18

feat: create React combobox component

d7355a3

feat: re-export the new React-Combobox

65fa1a6

docs: add Combobox stories

5c7c6d2

chore: create ComboboxPopoverProps interface

bdf6c0b

feat: create FormFieldCombobox react package

940f812

feat: re-export FormFieldCombobox component package

70d3654

AliKdhim87 force-pushed the feat/create-comboxbox branch from c709b71 to 70d3654 Compare October 29, 2024 13:23

AliKdhim87 requested a review from Robbert October 29, 2024 15:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: combobox React package #2453

feat: combobox React package #2453

AliKdhim87 commented Aug 30, 2024

vercel bot commented Aug 30, 2024 •

edited

Loading

codecov bot commented Sep 5, 2024 •

edited

Loading

Robbert left a comment

Robbert Sep 3, 2024

Robbert Sep 3, 2024

Robbert Sep 3, 2024

Robbert Sep 3, 2024

Robbert Sep 3, 2024

Robbert Sep 3, 2024

Robbert Oct 18, 2024

	Fix the button style issue when importe it from `dist/css-module`
	Fix the button style issue when importing it from `dist/css-module`.

	"description": "Button component for the Municipality of Utrecht based on the NL Design System architecture",
	"description": "Textbox component for the Municipality of Utrecht based on the NL Design System architecture",

feat: combobox React package #2453

Are you sure you want to change the base?

feat: combobox React package #2453

Conversation

AliKdhim87 commented Aug 30, 2024

vercel bot commented Aug 30, 2024 • edited Loading

codecov bot commented Sep 5, 2024 • edited Loading

Codecov Report

Robbert left a comment

Choose a reason for hiding this comment

Robbert Sep 3, 2024

Choose a reason for hiding this comment

Robbert Sep 3, 2024

Choose a reason for hiding this comment

Robbert Sep 3, 2024

Choose a reason for hiding this comment

Robbert Sep 3, 2024

Choose a reason for hiding this comment

Robbert Sep 3, 2024

Choose a reason for hiding this comment

Robbert Sep 3, 2024

Choose a reason for hiding this comment

Robbert Oct 18, 2024

Choose a reason for hiding this comment

vercel bot commented Aug 30, 2024 •

edited

Loading

codecov bot commented Sep 5, 2024 •

edited

Loading