Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Select Combobox component #2611

Merged
merged 5 commits into from
Nov 10, 2024
Merged

feat: Select Combobox component #2611

merged 5 commits into from
Nov 10, 2024

Conversation

Robbert
Copy link
Member

@Robbert Robbert commented Nov 10, 2024

No description provided.

@Robbert Robbert force-pushed the feat/select-combobox branch 3 times, most recently from d7e00cf to df7cfdd Compare November 10, 2024 14:10
@Robbert Robbert marked this pull request as ready for review November 10, 2024 15:21
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 79.54545% with 18 lines in your changes missing coverage. Please review.

Project coverage is 90.52%. Comparing base (0510581) to head (a572e37).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...mponents-react/select-combobox-react/src/index.tsx 75.00% 15 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2611      +/-   ##
==========================================
- Coverage   91.14%   90.52%   -0.62%     
==========================================
  Files         193      196       +3     
  Lines        1614     1700      +86     
  Branches      336      370      +34     
==========================================
+ Hits         1471     1539      +68     
- Misses        142      155      +13     
- Partials        1        6       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbert Robbert merged commit 64d9157 into main Nov 10, 2024
12 of 14 checks passed
@Robbert Robbert deleted the feat/select-combobox branch November 10, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants