Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLAC-623 wikipedia citations #842

Merged
merged 6 commits into from
Dec 18, 2023

Conversation

CEdwardsBlasikiewicz
Copy link
Contributor

do tests for 'build_via' and 'build_access_date' seem redundant?

…onents--nla-blacklight

chore(main): release 2.11.1
…onents--nla-blacklight

chore(main): release 2.11.1
…onents--nla-blacklight

chore(main): release 2.11.1
…onents--nla-blacklight

chore(main): release 2.11.1
Copy link
Contributor

@yetti yetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should still include the tests for via and the access date. The format might be changed by someone else in the future and it's a simple check to run the tests and make sure what's expected is still there.

…onents--nla-blacklight

chore(main): release 2.11.1
Copy link
Contributor

Simplecov Report

Covered Threshold
95.99% 80%

…onents--nla-blacklight

chore(main): release 2.11.1
@CEdwardsBlasikiewicz CEdwardsBlasikiewicz merged commit bf7676c into feat/upgrade Dec 18, 2023
2 checks passed
@CEdwardsBlasikiewicz CEdwardsBlasikiewicz deleted the blac-623-wikipedia-citations branch December 18, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants