-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLAC-623 wikipedia citations #842
Merged
CEdwardsBlasikiewicz
merged 6 commits into
feat/upgrade
from
blac-623-wikipedia-citations
Dec 18, 2023
Merged
BLAC-623 wikipedia citations #842
CEdwardsBlasikiewicz
merged 6 commits into
feat/upgrade
from
blac-623-wikipedia-citations
Dec 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onents--nla-blacklight chore(main): release 2.11.1
…onents--nla-blacklight chore(main): release 2.11.1
…onents--nla-blacklight chore(main): release 2.11.1
…onents--nla-blacklight chore(main): release 2.11.1
yetti
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should still include the tests for via
and the access date. The format might be changed by someone else in the future and it's a simple check to run the tests and make sure what's expected is still there.
scott-yeadon
approved these changes
Dec 18, 2023
…onents--nla-blacklight chore(main): release 2.11.1
Simplecov Report
|
…onents--nla-blacklight chore(main): release 2.11.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do tests for 'build_via' and 'build_access_date' seem redundant?