Allow setting the Created timestamp #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements nlewo#89. Like `nixpkgs.dockerTools.buildImage`, let `nix2container.buildImage` take an optional `created` argument that will be set on the resulting image. For backwards compatibility, it defaults to `"0001-01-01T00:00:00Z"`. I did not implement support for passing `"now"`, as I don't need it. (cherry picked from commit ffafa5d)
|
Tests passed locally (the CI is failing since several months and i don't have time to investigate). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #89.
Like
nixpkgs.dockerTools.buildImage, letnix2container.buildImagetake an optionalcreatedargument that will be set on the resulting image. For backwards compatibility, it defaults to"0001-01-01T00:00:00Z".I did not implement support for passing
"now", as I don't need it.(cherry picked from commit ffafa5d)