Refactor AiChat useEffect hook #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Renamed the inner function to updateAiChatProps for clarity and readability.
2)Moved the call to handleNewPropsReceived inside the updateAiChatProps function to encapsulate the logic for updating the AI chat props.
3) Ensured that the update of AI chat props is only performed if isUseEffectCancelled is false, new props are available, and the AI chat instance (aiChat.current) exists.
4)Updated the useEffect dependency array to include props and currentProps for proper dependency tracking.
|
@divyeshradadiya Thank you for your pull request. Merging. FYI: I'm in the process of re-factoring / re-writing the entire React part of the project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2)Moved the call to handleNewPropsReceived inside the updateAiChatProps function to encapsulate the logic for updating the AI chat props.
4)Updated the useEffect dependency array to include props and currentProps for proper dependency tracking.