Skip to content

Commit

Permalink
fix: do not handle instances of eTLD domains as errors
Browse files Browse the repository at this point in the history
  • Loading branch information
maeb committed Jan 17, 2024
1 parent 9ffbff8 commit c77e623
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions internal/keyvalue/report.go
Original file line number Diff line number Diff line change
Expand Up @@ -148,14 +148,13 @@ func (r ReportGenerator) Generate(ctx context.Context, req index.Request) (*sche
default:
}
resp = result.(CdxResponse)
key = make([]byte, len(resp.Key))
copy(key, resp.Key)
log.Debug().Str("key", string(key)).Msg("")
key = resp.Key
cdx = resp.Value

report.Progress = string(key)

if tock || updateCount%r.UpdateThreshold == 0 {
report.Duration = durationpb.New(time.Since(report.StartTime.AsTime()))
report.Progress = string(key)
updateCount = 0

err = r.SaveReport(ctx, report)
Expand All @@ -181,11 +180,13 @@ func (r ReportGenerator) Generate(ctx context.Context, req index.Request) (*sche
reportData.NrOfDomains++

// Update target
domain := deSurtDomain(surtDomain)
prevTarget = target
target, err = publicsuffix.EffectiveTLDPlusOne(deSurtDomain(surtDomain))
target, err = publicsuffix.EffectiveTLDPlusOne(domain)
if err != nil {
err = fmt.Errorf("failed to get effective tld plus one for '%s': %w", surtDomain, err)
return
log.Warn().Err(err).Str("domain", domain).Msg("failed to get effective tld plus one")
err = nil
target = domain
}
if prevTarget != target {
// Increment number of targets
Expand Down

0 comments on commit c77e623

Please sign in to comment.