-
-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Remove template before get in REAMD.md and docs in non-template context
#4846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request has been marked as stale because it has had no activity for 30 days. While we won’t close it automatically, we encourage you to update or comment if it is still relevant. Keeping pull requests active and up-to-date helps us review and merge changes more efficiently. Thank you for your contributions! |
…ate context Signed-off-by: Andy Choi <[email protected]>
get instead of template get in REAMD.md and docs in non-template contexttemplate before get in REAMD.md and docs in non-template context
|
Hi @nlohmann I've just updated this PR to keep it current. I noticed this is similar to #4920. After a comparison, I believe my PR #4846 is more comprehensive as it covers more files (23 files changed). My PR is also more thorough because I've fixed the comment indentation that was affected by the change. For example, PR #4920 leaves the comment on the next line misaligned (Line 931), while my PR corrects it to maintain code style (Line 931). Thank you for your time. |
|
This pull request has been marked as stale because it has had no activity for 30 days. While we won’t close it automatically, we encourage you to update or comment if it is still relevant. Keeping pull requests active and up-to-date helps us review and merge changes more efficiently. Thank you for your contributions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
|
Thanks a lot! |
Using
getinstead oftemplate getin REAMD.md and docs issue 4823make amalgamate.Read the Contribution Guidelines for detailed information.