Skip to content

Conversation

@ccpong
Copy link
Contributor

@ccpong ccpong commented Jul 12, 2025

Using get instead of template get in REAMD.md and docs issue 4823

  • The changes are described in detail, both the what and why.
  • If applicable, an issue 4823 is referenced.
  • The Code coverage remained at 100%. A test case for every new line of code.
  • If applicable, the documentation is updated.
  • The source code is amalgamated by running make amalgamate.

Read the Contribution Guidelines for detailed information.

@coveralls
Copy link

coveralls commented Jul 12, 2025

Coverage Status

coverage: 99.191%. remained the same
when pulling 4d869ff on ccpong:issue4823
into 44bee1b on nlohmann:develop.

@github-actions
Copy link

This pull request has been marked as stale because it has had no activity for 30 days. While we won’t close it automatically, we encourage you to update or comment if it is still relevant. Keeping pull requests active and up-to-date helps us review and merge changes more efficiently. Thank you for your contributions!

@github-actions github-actions bot added the state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated label Aug 12, 2025
@ccpong ccpong changed the title Use get instead of template get in REAMD.md and docs in non-template context Remove template before get in REAMD.md and docs in non-template context Sep 23, 2025
@ccpong
Copy link
Contributor Author

ccpong commented Sep 23, 2025

Hi @nlohmann

I've just updated this PR to keep it current.

I noticed this is similar to #4920. After a comparison, I believe my PR #4846 is more comprehensive as it covers more files (23 files changed).

My PR is also more thorough because I've fixed the comment indentation that was affected by the change. For example, PR #4920 leaves the comment on the next line misaligned (Line 931), while my PR corrects it to maintain code style (Line 931).

Thank you for your time.

@github-actions github-actions bot removed the state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated label Sep 24, 2025
@github-actions
Copy link

This pull request has been marked as stale because it has had no activity for 30 days. While we won’t close it automatically, we encourage you to update or comment if it is still relevant. Keeping pull requests active and up-to-date helps us review and merge changes more efficiently. Thank you for your contributions!

@github-actions github-actions bot added the state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated label Oct 25, 2025
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann removed the state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated label Oct 30, 2025
@nlohmann nlohmann added this to the Release 3.12.1 milestone Oct 30, 2025
@nlohmann nlohmann linked an issue Oct 30, 2025 that may be closed by this pull request
2 tasks
@nlohmann nlohmann merged commit cda9c1e into nlohmann:develop Oct 30, 2025
138 checks passed
@nlohmann
Copy link
Owner

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

README.md and documentation overuse template keyword before get function

3 participants