Add authentication using API key #214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the changes made to the openapi specification of the data node described in this PR.
The README has been updated with information on how to set the value of the API key.
Before merging this PR, we need to make sure that the benchmarking infra is able to use a data node protected by an API key. Updating the NLP Sandbox client for Python should not be too difficult using the openapi-generator. I did the same thing in another project but for a TypeScript client and it was very easy. I will give it a shot and open a PR for the Python client to update the part of the library that is automatically generated by the openapi-generator. @thomasyu888 could then update the SDK part of the client.
It may not be straightforward to let the NLP Sandbox controller know about the API key value it should use when sending request to a data node instance according to Tom.
@thomasyu888 - Can you comment on the difficulties you mentioned this morning? If we can let a controller know the API address of a data node (different IP address used by the MCW controller and Sage controller), why can't we specify the API key in the same way?