Update project #93
Open
Update project #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cascadianblue Can you please address the comment on line 9 of the Dockerfile? |
|
@cascadianblue Can you please also review |
Sorry, I don't understand the TODO: Which files are we trying to copy/not copy in this line? |
boyleconnor
reviewed
Jul 29, 2021
client/Dockerfile
Outdated
| RUN npm ci --silent | ||
| RUN npm install [email protected] -g --silent | ||
|
|
||
| # TODO Either copy file individually or use this line + .gitignore |
There was a problem hiding this comment.
As Thomas and I just discussed, this should probably follow the example of one of the example annotators, e.g. https://github.com/nlpsandbox/person-name-annotator-example/blob/8423e95c924d1232f68560127815dacfd3a4ccd0/server/Dockerfile#L19
(".gitignore" should be ".dockerignore")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #92