Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Buffer Size #96

Merged
merged 2 commits into from
Apr 6, 2021

Conversation

boyleconnor
Copy link
Collaborator

The NginX reverse proxy sometimes increases the request block sizes to more than the default maximum for this server. This fixes issue nlpsandbox/phi-deidentifier-app#46.

The NginX reverse proxy sometimes increases the request block sizes to
more than the default maximum for this server. This addresses issue
nlpsandbox/phi-deidentifier-app#46.
@boyleconnor boyleconnor self-assigned this Mar 10, 2021
@boyleconnor boyleconnor added the Bug Something isn't working label Mar 10, 2021
@boyleconnor
Copy link
Collaborator Author

@tschaffter any chance of getting this merged soon? It's currently a breaking bug in production

@tschaffter
Copy link
Member

It's currently a breaking bug in production

@cascadianblue Sorry about the late reply. If the solution solves the issue, then I'm going to merge even if we don't understand the issue yet. I'll find a way to keep this issue on my radar.

@tschaffter
Copy link
Member

@cascadianblue Can you please describe where the value buffer-size=32768 comes from?

@boyleconnor
Copy link
Collaborator Author

@tschaffter 32768 = 2^15. It is a somewhat arbitrary number (the upper limit on buffer size is 2^16 - 1 = 65535).

We can set it smaller if you prefer (I don't think any of the blocks I observed in the error logs were larger than the 5000s), but I think it should be at least 2^13 = 8192.

@tschaffter tschaffter merged commit b2eea5b into nlpsandbox:develop Apr 6, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants