Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin API for listing all tokens of an identity #999

Merged
merged 33 commits into from
Jan 17, 2025
Merged

Admin API for listing all tokens of an identity #999

merged 33 commits into from
Jan 17, 2025

Conversation

ericbrunner
Copy link
Contributor

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@ericbrunner ericbrunner added the enhancement New feature or request label Dec 19, 2024
@ericbrunner ericbrunner enabled auto-merge (squash) December 19, 2024 10:28
mergify bot added 19 commits December 20, 2024 06:34
@mergify
Merge branch 'main' into ABL-440-admin-api-for-listing-all-tokens-of-…
06667a4 
…an-identity
@mergify
Merge branch 'main' into ABL-440-admin-api-for-listing-all-tokens-of-…
6d77772 
…an-identity
@mergify
Merge branch 'main' into ABL-440-admin-api-for-listing-all-tokens-of-…
b248db6 
…an-identity
@mergify
Merge branch 'main' into ABL-440-admin-api-for-listing-all-tokens-of-…
efc2848 
…an-identity
@mergify
Merge branch 'main' into ABL-440-admin-api-for-listing-all-tokens-of-…
ee0ce56 
…an-identity
@mergify
Merge branch 'main' into ABL-440-admin-api-for-listing-all-tokens-of-…
dee85b7 
…an-identity
@mergify
Merge branch 'main' into ABL-440-admin-api-for-listing-all-tokens-of-…
b746f06 
…an-identity
@mergify
Merge branch 'main' into ABL-440-admin-api-for-listing-all-tokens-of-…
407d4fc 
…an-identity
@mergify
Merge branch 'main' into ABL-440-admin-api-for-listing-all-tokens-of-…
e24a11e 
…an-identity
@mergify
Merge branch 'main' into ABL-440-admin-api-for-listing-all-tokens-of-…
6936da7 
…an-identity
@mergify
Merge branch 'main' into ABL-440-admin-api-for-listing-all-tokens-of-…
c790ca1 
…an-identity
@mergify
Merge branch 'main' into ABL-440-admin-api-for-listing-all-tokens-of-…
4e4b0a2 
…an-identity
@mergify
Merge branch 'main' into ABL-440-admin-api-for-listing-all-tokens-of-…
1272160 
…an-identity
@mergify
Merge branch 'main' into ABL-440-admin-api-for-listing-all-tokens-of-…
040d115 
…an-identity
@mergify
Merge branch 'main' into ABL-440-admin-api-for-listing-all-tokens-of-…
69bfed8 
…an-identity
@mergify
Merge branch 'main' into ABL-440-admin-api-for-listing-all-tokens-of-…
dbb82f3 
…an-identity
@mergify
Merge branch 'main' into ABL-440-admin-api-for-listing-all-tokens-of-…
f56dfea 
…an-identity
@mergify
Merge branch 'main' into ABL-440-admin-api-for-listing-all-tokens-of-…
ca2fe87 
…an-identity
@mergify
Merge branch 'main' into ABL-440-admin-api-for-listing-all-tokens-of-…
0a0e999 
…an-identity
@tnotheis tnotheis changed the title Abl 440 admin api for listing all tokens of an identity Admin API for listing all tokens of an identity Jan 15, 2025
tnotheis
tnotheis requested changes Jan 15, 2025
View reviewed changes
Copy link
Member

@tnotheis tnotheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I told you it's not necessary to write an integration test for this functionality (because we can't create tokens via the Admin API), but I just thought about it, and I think we could at least add one like "Listing all tokens of an identity that doesn't have any tokens".
This ensures that all DI wiring has been done correctly and that all dependencies can be resolved.

Applications/AdminApi/src/AdminApi/Extensions/IServiceCollectionExtensions.cs Outdated Show resolved Hide resolved
Applications/AdminApi/src/AdminApi/appsettings.json Outdated Show resolved Hide resolved
Applications/AdminApi/src/AdminApi/Extensions/TokensServiceCollectionExtensions.cs Outdated Show resolved Hide resolved
Modules/Tokens/src/Tokens.Application/Tokens/Queries/ListTokensByIdentity/Validator.cs Outdated Show resolved Hide resolved
@ericbrunner
Copy link
Contributor Author

I know I told you it's not necessary to write an integration test for this functionality (because we can't create tokens via the Admin API), but I just thought about it, and I think we could at least add one like "Listing all tokens of an identity that doesn't have any tokens". This ensures that all DI wiring has been done correctly and that all dependencies can be resolved.

Check last commit

@ericbrunner ericbrunner requested a review from tnotheis January 16, 2025 08:39
tnotheis
tnotheis previously approved these changes Jan 17, 2025
View reviewed changes
@tnotheis tnotheis disabled auto-merge January 17, 2025 08:36
@tnotheis tnotheis merged commit ba36743 into main Jan 17, 2025
21 of 22 checks passed
@tnotheis tnotheis deleted the ABL-440-admin-api-for-listing-all-tokens-of-an-identity branch January 17, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnotheis tnotheis tnotheis left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericbrunner @tnotheis