Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new termination and reactivation routes #191

Merged
merged 20 commits into from
Jul 9, 2024
Merged

Add new termination and reactivation routes #191

merged 20 commits into from
Jul 9, 2024

Conversation

sebbi08
Copy link
Contributor

@sebbi08 sebbi08 commented Jun 20, 2024 •
edited by jkoenig134
Loading

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@sebbi08 sebbi08 force-pushed the feature/implement-relationship-termination branch from be82e9f to 94130ed Compare June 20, 2024 10:23
@sebbi08 sebbi08 changed the title Feature/ Implement new termination and reactivation routes Feature/Implement new termination and reactivation routes Jun 20, 2024
@sebbi08 sebbi08 added the enhancement New feature or request label Jun 21, 2024
@jkoenig134 jkoenig134 changed the title Feature/Implement new termination and reactivation routes Add new termination and reactivation routes Jun 25, 2024
Magnus-Kuhn
Magnus-Kuhn reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@Magnus-Kuhn Magnus-Kuhn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only had objections against the openapi descriptions, however the existing openapi has not set a high standard with its inconsistent quality.

src/modules/coreHttpApi/openapi.yml Outdated Show resolved Hide resolved
src/modules/coreHttpApi/openapi.yml Outdated Show resolved Hide resolved
src/modules/coreHttpApi/openapi.yml Outdated Show resolved Hide resolved
src/modules/coreHttpApi/openapi.yml Outdated Show resolved Hide resolved
src/modules/coreHttpApi/openapi.yml Outdated Show resolved Hide resolved
src/modules/coreHttpApi/openapi.yml Outdated Show resolved Hide resolved
src/modules/coreHttpApi/openapi.yml Outdated Show resolved Hide resolved
src/modules/coreHttpApi/openapi.yml Outdated Show resolved Hide resolved
src/modules/coreHttpApi/openapi.yml Outdated Show resolved Hide resolved
src/modules/coreHttpApi/openapi.yml Outdated Show resolved Hide resolved
@jkoenig134
Copy link
Member

I only had objections against the openapi descriptions, however the existing openapi has not set a high standard with its inconsistent quality.

@Magnus-Kuhn good catch. Relationship Changes are scattered all over the api docs... This has to be fixed before merging this.

jkoenig134
jkoenig134 reviewed Jul 3, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
jkoenig134
jkoenig134 requested changes Jul 8, 2024
View reviewed changes
src/modules/coreHttpApi/openapi.yml Outdated Show resolved Hide resolved
src/modules/coreHttpApi/openapi.yml Show resolved Hide resolved
src/modules/coreHttpApi/openapi.yml Outdated Show resolved Hide resolved
jkoenig134
jkoenig134 previously approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@jkoenig134 jkoenig134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Magnus-Kuhn
Copy link
Contributor

wait a sec... there is still a creation change in a module and a relationship request in the openapi - I'm working on them

@Magnus-Kuhn
Copy link
Contributor

wait a sec... there is still a creation change in a module and a relationship request in the openapi - I'm working on them
I'm done

@sebbi08 sebbi08 merged commit 53bb1e9 into release/v5 Jul 9, 2024
9 checks passed
@sebbi08 sebbi08 deleted the feature/implement-relationship-termination branch July 9, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnotheis tnotheis tnotheis left review comments

@Magnus-Kuhn Magnus-Kuhn Magnus-Kuhn left review comments

@jkoenig134 jkoenig134 jkoenig134 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebbi08 @jkoenig134 @Magnus-Kuhn @tnotheis