Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper Wording in Deletion CLI #339

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Proper Wording in Deletion CLI #339

merged 1 commit into from
Jan 8, 2025

Conversation

jkoenig134
Copy link
Member

@jkoenig134 jkoenig134 commented Jan 8, 2025 •
edited
Loading

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

Description

@sebbi08 in #308 you named an address an id. Please make sure to inform about the differences.

@jkoenig134 jkoenig134 added the bug Something isn't working label Jan 8, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/cli/commands/identity/status.ts 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/cli/commands/identity/status.ts 65.11% <0.00%> (ø)

... and 13 files with indirect coverage changes

@jkoenig134 jkoenig134 merged commit 4ae61a0 into main Jan 8, 2025
11 checks passed
@jkoenig134 jkoenig134 deleted the proper-wording branch January 8, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebbi08 sebbi08 sebbi08 approved these changes

@britsta britsta britsta approved these changes

@Milena-Czierlinski Milena-Czierlinski Awaiting requested review from Milena-Czierlinski

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkoenig134 @sebbi08 @britsta