Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createdBy in RelationshipAuditLogEntry is documented as date-time #352

Merged
merged 3 commits into from
Jan 27, 2025
Merged

createdBy in RelationshipAuditLogEntry is documented as date-time #352

merged 3 commits into from
Jan 27, 2025

Conversation

jkoenig134
Copy link
Member

@jkoenig134 jkoenig134 commented Jan 27, 2025 •
edited
Loading

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

Description

Fixes nmshd/feedback#32

@jkoenig134 jkoenig134 added the bug Something isn't working label Jan 27, 2025
@jkoenig134 jkoenig134 requested a review from tnotheis January 27, 2025 09:26
@codecov Codecov
Copy link

codecov bot commented Jan 27, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/modules/sse/SseModule.ts 0.00% <ø> (ø)

@jkoenig134 jkoenig134 merged commit d2630c4 into main Jan 27, 2025
8 checks passed
@jkoenig134 jkoenig134 deleted the createdby-in-relationship-audit-log-is-documented-as-datetime branch January 27, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnotheis tnotheis tnotheis approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Connector API docs: auditLog createdBy does not match format
2 participants
@jkoenig134 @tnotheis