Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RunLayerContext] Unused property and its relevant methods are removed #2851

Merged
merged 1 commit into from
Jan 3, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions nntrainer/layers/layer_context.h
Original file line number Diff line number Diff line change
Expand Up @@ -901,21 +901,6 @@ class RunLayerContext {
*/
std::vector<Weight *> getWeights() { return weights; }

/**
* @brief set the compute engine for this node
* @param compute engine: (CPU/GPU)
*/
void setComputeEngine(const ml::train::LayerComputeEngine &compute_engine =
ml::train::LayerComputeEngine::CPU) {
this->compute_engine = compute_engine;
}

/**
* @brief get the compute engine for this node
* @return ompute engine: (CPU/GPU)
*/
ml::train::LayerComputeEngine getComputeEngine() { return compute_engine; }

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still have:

ml::train::LayerComputeEngine compute_engine =
ml::train::LayerComputeEngine::CPU;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the comment! I've updated it :)

/**
* @brief get loss scale
* @return loss scale
Expand Down Expand Up @@ -958,9 +943,6 @@ class RunLayerContext {
std::vector<Var_Grad *> outputs; /**< outputs of the layer */
std::vector<Var_Grad *> tensors; /**< tensors of the layer */

ml::train::LayerComputeEngine compute_engine =
ml::train::LayerComputeEngine::CPU;

#ifdef DEBUG
std::map<std::string, const void *>
tensor_map; /**< map of tensor name to tensor address */
Expand Down
Loading