-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: New URL for NNStreamer Latest Android Build #2880
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nnstreamer-lite-*.zip will be released with this PR: nnstreamer/api#595 |
ba9eb3c
to
58f121f
Compare
@djeong20 Please Check & apply below For now we can use REGEX for S3 URL download, so @gichan-jang will upload nnstreamer-lite latest file as fixed name FILE_PREFIX=nnstreamer-lite-native
ZIP_NAME=${FILE_PREFIX}.zip
URL="https://nnstreamer-release.s3-ap-northeast-2.amazonaws.com/nnstreamer/latest/android/nnstreamer-lite-native.zip"
echo "PREPARING ml_api at ${TARGET}"
[ ! -d ${TARGET} ] && mkdir -p ${TARGET}
pushd ${TARGET}
function _download_ml_api {
[ -f $ZIP_NAME ] && echo "${ZIP_NAME} exists, skip downloading" && return 0
echo "[ml_api] downloading ${ZIP_NAME}\n"
if ! wget -r -l1 -nH --cut-dirs=3 ${URL} ; then
echo "[ml_api] Download failed, please check url\n"
exit $?
fi
echo "[ml_api] Finish downloading ml_api\n"
} |
for now (temp url), nntrainer team can use this script for android build set -e
TARGET=$1
# Note: zip name can be nnstreamer-native-*.zip but this file is heavier to download
FILE_PREFIX=nnstreamer-lite-native
ZIP_NAME_REGEX=${FILE_PREFIX}-*.zip
ZIP_NAME=${FILE_PREFIX}.zip
#URL="https://release.nnstreamer.com/#nnstreamer/latest/android/"
URL="https://nnstreamer-release.s3-ap-northeast-2.amazonaws.com/nnstreamer/latest/android/nnstreamer-lite-native-2025-01-16.zip"
echo "PREPARING ml_api at ${TARGET}"
[ ! -d ${TARGET} ] && mkdir -p ${TARGET}
pushd ${TARGET}
function _download_ml_api {
[ -f $ZIP_NAME ] && echo "${ZIP_NAME} exists, skip downloading" && return 0
echo "[ml_api] downloading ${ZIP_NAME}\n"
# if ! wget -r -l1 -nH --cut-dirs=6 ${URL} -A ${ZIP_NAME_REGEX} -O ${ZIP_NAME} ; then
if ! wget -r -l1 -nH --cut-dirs=3 ${URL} -O ${ZIP_NAME} ; then
echo "[ml_api] Download failed, please check url\n"
exit $?
fi
echo "[ml_api] Finish downloading ml_api\n"
} |
58f121f
to
484a9d8
Compare
@DonghakPark Thank you for your feedback! I've updated the script to download the latest zip file based on the date, as this is the current method, so no extra work will be needed @gichan-jang. |
I could also confirm that I tested this PR on my local and found the successful build. Great work! |
This PR updates the URL of the NNStreamer's latest android build result. The previous URL is deprecated and is no longer be updated. **Self-evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Donghyeon Jeong <[email protected]>
484a9d8
to
a1d8f49
Compare
This PR updates the URL of the NNStreamer's latest android build result.
The previous URL is deprecated and is no longer be updated.
Self-evaluation: