Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: New URL for NNStreamer Latest Android Build #2880

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

djeong20
Copy link
Contributor

This PR updates the URL of the NNStreamer's latest android build result.
The previous URL is deprecated and is no longer be updated.

Self-evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

Copy link
Collaborator

@dkjung dkjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@DonghakPark DonghakPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@skykongkong8 skykongkong8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@EunjuYang EunjuYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@lhs8928 lhs8928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jijoongmoon jijoongmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gichan-jang
Copy link
Member

nnstreamer-lite-*.zip will be released with this PR: nnstreamer/api#595

jni/prepare_ml-api.sh Outdated Show resolved Hide resolved
@DonghakPark
Copy link
Member

@djeong20 Please Check & apply below

For now we can use REGEX for S3 URL download, so @gichan-jang will upload nnstreamer-lite latest file as fixed name nnstreamer-lite-native.zip

FILE_PREFIX=nnstreamer-lite-native
ZIP_NAME=${FILE_PREFIX}.zip
URL="https://nnstreamer-release.s3-ap-northeast-2.amazonaws.com/nnstreamer/latest/android/nnstreamer-lite-native.zip"

echo "PREPARING ml_api at ${TARGET}"

[ ! -d ${TARGET} ] && mkdir -p ${TARGET}

pushd ${TARGET}

function _download_ml_api {
  [ -f $ZIP_NAME ] && echo "${ZIP_NAME} exists, skip downloading" && return 0
  echo "[ml_api] downloading ${ZIP_NAME}\n"
    if ! wget -r -l1 -nH --cut-dirs=3 ${URL} ; then
    echo "[ml_api] Download failed, please check url\n"
    exit $?
  fi
  echo "[ml_api] Finish downloading ml_api\n"
}

@DonghakPark
Copy link
Member

for now (temp url), nntrainer team can use this script for android build

set -e
TARGET=$1
# Note: zip name can be nnstreamer-native-*.zip but this file is heavier to download
FILE_PREFIX=nnstreamer-lite-native
ZIP_NAME_REGEX=${FILE_PREFIX}-*.zip
ZIP_NAME=${FILE_PREFIX}.zip
#URL="https://release.nnstreamer.com/#nnstreamer/latest/android/"
URL="https://nnstreamer-release.s3-ap-northeast-2.amazonaws.com/nnstreamer/latest/android/nnstreamer-lite-native-2025-01-16.zip"

echo "PREPARING ml_api at ${TARGET}"

[ ! -d ${TARGET} ] && mkdir -p ${TARGET}

pushd ${TARGET}

function _download_ml_api {
  [ -f $ZIP_NAME ] && echo "${ZIP_NAME} exists, skip downloading" && return 0
  echo "[ml_api] downloading ${ZIP_NAME}\n"
#  if ! wget -r -l1 -nH --cut-dirs=6 ${URL} -A ${ZIP_NAME_REGEX} -O ${ZIP_NAME} ; then
    if ! wget -r -l1 -nH --cut-dirs=3 ${URL} -O ${ZIP_NAME} ; then
    echo "[ml_api] Download failed, please check url\n"
    exit $?
  fi
  echo "[ml_api] Finish downloading ml_api\n"
}

@djeong20
Copy link
Contributor Author

@DonghakPark Thank you for your feedback! I've updated the script to download the latest zip file based on the date, as this is the current method, so no extra work will be needed @gichan-jang.

@skykongkong8
Copy link
Member

I could also confirm that I tested this PR on my local and found the successful build. Great work!

This PR updates the URL of the NNStreamer's latest android build result.
The previous URL is deprecated and is no longer be updated.

**Self-evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test:   [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghyeon Jeong <[email protected]>
@jijoongmoon jijoongmoon merged commit ea7a1a0 into nnstreamer:main Jan 16, 2025
17 checks passed
@djeong20 djeong20 deleted the fix/ml-api/url branch January 22, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PR/READY2MERGE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants