Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ neon ] Implement neon kernel for copy_s16_f32 #2881

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

skykongkong8
Copy link
Member

  • load for s16, widen to s32, convert to f32, and store.
  • Add fallback function with the same function param for easier later refactor.

Self evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: skykongkong8 [email protected]

@skykongkong8 skykongkong8 changed the title [ Wait for #2876 ] [ neon ] Implement neon kernel for copy_s16_f32 [ neon ] Implement neon kernel for copy_s16_f32 Jan 20, 2025
@skykongkong8
Copy link
Member Author

#2882 should be merged in order to pass the CI (Android build)

Copy link
Contributor

@djeong20 djeong20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

- load for s16, widen to s32, convert to f32, and store.
- Add fallback function with the same function param for easier later refactor.

**Self evaluation:**
1. Build test:     [X]Passed [ ]Failed [ ]Skipped
2. Run test:     [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: skykongkong8 <[email protected]>
@skykongkong8
Copy link
Member Author

Will rebase after #2892

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants