[Wait for #2889] [Subgraph] Add unittest for subgraph. #2894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bGraphBase` - Moved the defined behavior from `NetworkGraph` to `SubGraphBase`. - Updated public methods of `NetworkGraph` to pass their behaviors to `SubGraphBase`. - Removed unused private methods in `NetworkGraph`. Signed-off-by: Eunju Yang <[email protected]>
…o SubGraphBase - Update the definition of forwarding operations in neuralnet to be defined within each subgraph type. - Modify the implementation so that both forwarding and incremental_forwarding can now be defined individually for each subgraph type. Signed-off-by: Eunju Yang <[email protected]>
- Update the definition of backwarding operations in neuralnet to be defined within each subgraph type. - `applyGradients` is also updated without taking any callback from outside. Signed-off-by: Eunju Yang <[email protected]>
… tests - Updated `SubGraphBase` to inherit `GraphNode` - Changed the `graph` type inside `NetworkGraph` from `SubGraphBase` to `GraphCore`, using `SubGraphBase` as its `GraphNode` type. - Allowed for the addition of multiple `SubGraphBase` graph nodes in the future. - Assumed that NetworkGraph always has a `default_subgraph` called default_subgraph, and updated the existing code to maintain compatibility. - Updated the relevant unit test codes. Signed-off-by: Eunju Yang <[email protected]>
- Refactored the input and label setup logic for subgraphs by splitting them into separate functions: `setInputs()` and `setLabels()`. - Introduced new functions `setInputs()` and `setLabels()` to handle input and label setups independently for each subgraph. Signed-off-by: Eunju Yang <[email protected]>
…hCpu` - Updated the base class `SubGraphBase` to become a virtual base class and implemented a derived class `SubGraphCpu`. - Set up `NetworkGraph` to default to creating and utilizing one instance of `SubGraphCpu`. - Declared several member functions related to memory management and computation engines as pure virtual functions (=0) in `SubGraphBase`. Signed-off-by: Eunju Yang <[email protected]>
- This commit adds a `graph_scope` property to designate the subgraph, which a layer belongs to. - This commit updates NetworkGraph's addLayer function to check the GraphName of the layer and create a subgraph if the graph doesn't exist. Signed-off-by: Eunju Yang <[email protected]>
- The previous version didn't implement a constructor for subgraph initialization. - This commit resolves the issue. Signed-off-by: Eunju Yang <[email protected]>
- This commit renames the alias for `GraphRepresentation` to `GraphLayerNodeRepresentation` - The reason we do this is to update the GraphRepresentation as the serialized SubGraphBase pointer, not LayerNode Signed-off-by: Eunju Yang <[email protected]>
- Renamed `GraphName` to `SubGraphName`. - Updated keyword for `SubGraphName` attribute to `subgraph_name` - Made corresponding changes. Signed-off-by: Eunju Yang <[email protected]>
- This commit aims to add an api to create SubGraph object. - To this end, this commit updates some features of SubGraph class including setting up its property. - subgraph.h/.cpp are added to wrap all the subgraph classes. - alias for `GraphRepresentation` and `SubGraphNode` are added. Signed-off-by: Eunju Yang <[email protected]>
…ph handling This commit separates the realize() step from compile() in the neural net module, enabling independent management of the realization process for both inter-subgraphs and intra-subgraphs. Specifically focusing on intra-subgraphs, this commit introduces the implementation of the realize() function. Notable changes include: - Implementation of `addSubGraph` method for `NetworkGraph`. - Addition of a dedicated constructor for `NetworkGraph`, particularly invoked during compilation. This constructor triggers the realize() call. - Relocation of the initial action applying realisers to SubGraphBase to facilitate splitting the realization action across NetworkGraph and SubGraph. - Adding graph_representation and graph_map attributes into the `NeuralNet` class to manage subgraph-level representations effectively. Signed-off-by: Eunju Yang <[email protected]>
- Add a brief explanation to `subgraph.cpp` Signed-off-by: Eunju Yang <[email protected]>
In this commit, I've added test cases for the `createSubGraph()` function to ensure the correctness of the `subgraph_name` property. Signed-off-by: Eunju Yang <[email protected]>
EunjuYang
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
gichan-jang,
anyj0527,
lhs8928,
songgot,
jihochu,
DonghakPark,
SeoHyungjun,
baek2sm,
skykongkong8 and
djeong20
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of new commits
createSubGraph()function to ensure the correctness of the
subgraph_nameproperty. This commit only tests thesubgraph_nameproperty.Self evaluation:
Build test: [x]Passed [ ]Failed [ ]Skipped
Run test: [x]Passed [ ]Failed [ ]Skipped
see also #2864