meson: avx condition fix. #2902
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myungjoo
requested review from
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
gichan-jang,
anyj0527,
lhs8928,
songgot,
jihochu,
DonghakPark,
SeoHyungjun,
baek2sm,
skykongkong8,
djeong20,
EunjuYang,
dkjung and
haehun
as code owners
enable-avx=true is the default option, which breaks the build in other archs in general. 1. Ignore AVX if arch is not x64/x86. 2. Reading get_option should be done only once. Fixed for enable-avx. 2. Corrected the buggy AVX condition. This fix is required by RISC-V. Signed-off-by: MyungJoo Ham <[email protected]>
myungjoo
force-pushed
the
fix_arch_avx
branch
from
bd340ab to
59ba19e
Compare
djeong20
approved these changes
Jan 24, 2025
| if avx_enabled == true | ||
| tensor_sources += 'blas_avx.cpp' | ||
| tensor_headers += 'blas_avx.h' | ||
| avx_enabled = true |
There was a problem hiding this comment.
Suggested change
| avx_enabled = true |
remove?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable-avx=true is the default option, which breaks the build in other archs in general.
This fix is required by RISC-V: #2638